Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markup doesn't like spans in the middle of escape characters #637

Closed
davidwengier opened this issue Oct 13, 2020 · 1 comment · Fixed by #683
Closed

Markup doesn't like spans in the middle of escape characters #637

davidwengier opened this issue Oct 13, 2020 · 1 comment · Fixed by #683
Assignees
@sharwell
Labels
Area-MS.CA.Testing Microsoft.CodeAnalysis.Testing

Comments

@davidwengier
Copy link

davidwengier commented Oct 13, 2020 •
edited
Loading

Given:

//                       11     1   1
//             012345678901     2   3
string code = "class C { }\r{|b:\n|}";`

The markup produces a span at 12..14, and an output text of class C { }\r\r\n.

The span should be 12..13 and the output should only have one \r
@sharwell sharwell added the Area-MS.CA.Testing Microsoft.CodeAnalysis.Testing label Oct 15, 2020
sharwell added a commit to sharwell/roslyn-sdk that referenced this issue Dec 23, 2020
@sharwell
Add regression test for markup splitting line end
d783311 
Closes dotnet#637
@sharwell sharwell mentioned this issue Dec 23, 2020
Merged
@sharwell
Copy link
Member

I was not able to reproduce this. A regression test is added in #683.

@sharwell sharwell self-assigned this Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
Area-MS.CA.Testing Microsoft.CodeAnalysis.Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add regression test for markup splitting line end sharwell/roslyn-sdk
2 participants
@davidwengier @sharwell