Skip to content

Commit 160f268

Browse files
authored
In PR validation, test sign contents of nupkg, but not the nupkg itself (#79643)
This allows us to support test signing in PR validation builds. VS cloudbuild will not build with test signed packages (nuget reports certificate errors related to expiration), and we have no way in an insertion to specify that the PR should be queued with specific parameters to disable the errors. Instead, we can simply not sign the nuget packages (while still signing the contents to make sure subsequent steps like ngen see strong named dlls). val build - https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/657144
2 parents 257ee96 + 4ac37dd commit 160f268

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

eng/Signing.props

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,4 +61,13 @@
6161
<FileSignInfo Include="Microsoft.VisualStudio.Threading.dll" CertificateName="MicrosoftSHA2" />
6262
<FileSignInfo Include="StreamJsonRpc.dll" CertificateName="MicrosoftSHA2" />
6363
</ItemGroup>
64+
65+
<!--
66+
VS cloudbuild fails to restore when using test signed nuget packages due to certificate errors.
67+
To avoid this issue, we sign the package contents, but skip signing the actual package file.
68+
-->
69+
<ItemGroup Condition="'$(PreReleaseVersionLabel)' == 'pr-validation' And '$(DotNetSignType)' == 'test'">
70+
<FileExtensionSignInfo Update=".nupkg" CertificateName="None" />
71+
</ItemGroup>
72+
6473
</Project>

0 commit comments

Comments
 (0)