Remove mocks of setting services for unit tests

Rather than mocking a bunch of VS services that are involved in reading
services to be no-ops, we can just exclude the option persister to
start with. This just ensures they're better isolated no matter
what.

Author: jasonmalinowski

src/EditorFeatures/TestUtilities/StubLocalRegistry.cs

@@ -28,8 +28,6 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests
 
         Private ReadOnly _exportProvider As Composition.ExportProvider
         Private ReadOnly _fileChangeEx As New MockVsFileChangeEx
-        Private ReadOnly _localRegistry As New StubLocalRegistry
-        Private _settingsManager As ISettingsManager
 
         Public MockMonitorSelection As IVsMonitorSelection
 
@@ -61,17 +59,6 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests
                 Case GetType(SVsFileChangeEx)
                     Return _fileChangeEx
 
-                Case GetType(SLocalRegistry)
-                    Return _localRegistry
-
-                Case GetType(SVsSettingsPersistenceManager)
-                    If _settingsManager Is Nothing Then
-                        LoggerFactory.Reset()
-                        _settingsManager = SettingsManagerFactory.CreateInstance(New StubSettingsManagerHost())
-                    End If
-
-                    Return _settingsManager
-
                 Case Else
                     Throw New Exception($"{NameOf(MockServiceProvider)} does not implement {serviceType.FullName}.")
             End Select

src/EditorFeatures/TestUtilities/StubSettingsManagerHost.cs

@@ -4,7 +4,6 @@
 
 Imports Microsoft.CodeAnalysis.Editor.Host
 Imports Microsoft.CodeAnalysis.Editor.UnitTests
-Imports Microsoft.CodeAnalysis.Notification
 Imports Microsoft.CodeAnalysis.Test.Utilities
 Imports Microsoft.VisualStudio.LanguageServices.CSharp
 Imports Microsoft.VisualStudio.LanguageServices.Remote
@@ -26,6 +25,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests
                 GetType(VisualStudioRemoteHostClientProvider.Factory), ' Do not use ServiceHub in VS unit tests, run services locally.
                 GetType(IStreamingFindUsagesPresenter),                ' TODO: should we be using the actual implementation (https://github.com/dotnet/roslyn/issues/46380)?
                 GetType(HACK_ThemeColorFixer),
-                GetType(Implementation.Notification.VSNotificationServiceFactory))
+                GetType(Implementation.Notification.VSNotificationServiceFactory),
+                GetType(Options.VisualStudioOptionPersisterProvider)) ' Unit tests shouldn't depend on environmental user settings that might be set (even if we could read them)
     End Class
 End Namespace