Move 'use auto prop' to code style layer. (#79737)

Author: CyrusNajmabadi

src/Analyzers/CSharp/CodeFixes/CSharpCodeFixes.projitems

@@ -96,6 +96,9 @@
     <Compile Include="$(MSBuildThisFileDirectory)UnsealClass\CSharpUnsealClassCodeFixProvider.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)UpdateProjectToAllowUnsafe\CSharpUpdateProjectToAllowUnsafeCodeFixProvider.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)UpgradeProject\CSharpUpgradeProjectCodeFixProvider.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)UseAutoProperty\CSharpUseAutoPropertyCodeFixProvider.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)UseAutoProperty\SingleLinePropertyFormattingRule.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)UseAutoProperty\UseAutoPropertyRewriter.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)UseExplicitArrayInExpressionTree\CSharpUseExplicitArrayInExpressionTreeCodeFixProvider.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\CSharpUseCoalesceExpressionForIfNullStatementCheckCodeFixProvider.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)UseCollectionExpression\CSharpCollectionExpressionRewriter.cs" />

src/Analyzers/CSharp/CodeFixes/ImplementInterface/CSharpImplementInterfaceService.cs

@@ -10,10 +10,8 @@
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp.CodeGeneration;
 using Microsoft.CodeAnalysis.CSharp.Extensions;
-using Microsoft.CodeAnalysis.CSharp.Formatting;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Editing;
-using Microsoft.CodeAnalysis.Formatting;
 using Microsoft.CodeAnalysis.Host.Mef;
 using Microsoft.CodeAnalysis.ImplementInterface;
 using Microsoft.CodeAnalysis.PooledObjects;
@@ -26,9 +24,6 @@ namespace Microsoft.CodeAnalysis.CSharp.ImplementInterface;
 [method: Obsolete(MefConstruction.ImportingConstructorMessage, error: true)]
 internal sealed class CSharpImplementInterfaceService() : AbstractImplementInterfaceService<TypeDeclarationSyntax>
 {
-    protected override ISyntaxFormatting SyntaxFormatting
-        => CSharpSyntaxFormatting.Instance;
-
     protected override SyntaxGeneratorInternal SyntaxGeneratorInternal
         => CSharpSyntaxGeneratorInternal.Instance;
 

src/Features/CSharp/Portable/UseAutoProperty/CSharpUseAutoPropertyCodeFixProvider.cs renamed to src/Analyzers/CSharp/CodeFixes/UseAutoProperty/CSharpUseAutoPropertyCodeFixProvider.cs

@@ -11,6 +11,7 @@
 using System.Threading.Tasks;
 using Microsoft.CodeAnalysis.CodeFixes;
 using Microsoft.CodeAnalysis.CSharp.Extensions;
+using Microsoft.CodeAnalysis.CSharp.Formatting;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Editing;
 using Microsoft.CodeAnalysis.FindSymbols;
@@ -38,6 +39,8 @@ internal sealed partial class CSharpUseAutoPropertyCodeFixProvider()
         ConstructorDeclarationSyntax,
         ExpressionSyntax>
 {
+    protected override ISyntaxFormatting SyntaxFormatting => CSharpSyntaxFormatting.Instance;
+
     protected override PropertyDeclarationSyntax GetPropertyDeclaration(SyntaxNode node)
         => (PropertyDeclarationSyntax)node;
 
@@ -222,7 +225,7 @@ protected override ImmutableArray<AbstractFormattingRule> GetFormattingRules(
         if (propertyDeclaration is PropertyDeclarationSyntax { AccessorList.Accessors: var accessors } &&
             accessors.All(a => a is { ExpressionBody: null, Body: null, AttributeLists.Count: 0 }))
         {
-            return [new SingleLinePropertyFormattingRule(), .. Formatter.GetDefaultFormattingRules(document)];
+            return [new SingleLinePropertyFormattingRule(), .. this.SyntaxFormatting.GetDefaultFormattingRules()];
         }
 
         return default;

src/Features/CSharp/Portable/UseAutoProperty/SingleLinePropertyFormattingRule.cs renamed to src/Analyzers/CSharp/CodeFixes/UseAutoProperty/SingleLinePropertyFormattingRule.cs

@@ -146,8 +146,7 @@ static async Task<SeparatedSyntaxList<ArgumentSyntax>> GetArgumentsAsync(
                 return default;
 
             var text = await document.GetTextAsync(cancellationToken).ConfigureAwait(false);
-            var formattingOptions = await document.GetSyntaxFormattingOptionsAsync(
-                CSharpSyntaxFormatting.Instance, cancellationToken).ConfigureAwait(false);
+            var formattingOptions = await document.GetSyntaxFormattingOptionsAsync(cancellationToken).ConfigureAwait(false);
 
             using var _ = ArrayBuilder<SyntaxNodeOrToken>.GetInstance(out var nodesAndTokens);
 

src/Features/CSharp/Portable/UseAutoProperty/UseAutoPropertyRewriter.cs renamed to src/Analyzers/CSharp/CodeFixes/UseAutoProperty/UseAutoPropertyRewriter.cs

@@ -25,7 +25,7 @@ public sealed partial class UseAutoPropertyTests(ITestOutputHelper logger)
     private readonly ParseOptions CSharp12 = CSharpParseOptions.Default.WithLanguageVersion(LanguageVersion.CSharp12);
 
     internal override (DiagnosticAnalyzer, CodeFixProvider) CreateDiagnosticProviderAndFixer(Workspace workspace)
-        => (new CSharpUseAutoPropertyAnalyzer(), GetCSharpUseAutoPropertyCodeFixProvider());
+        => (new CSharpUseAutoPropertyAnalyzer(), new CSharpUseAutoPropertyCodeFixProvider());
 
     [Fact]
     public Task TestSingleGetterFromField()

src/Analyzers/CSharp/CodeFixes/UseCollectionExpression/CSharpUseCollectionExpressionForFluentCodeFixProvider.cs

@@ -128,6 +128,8 @@
     <Compile Include="$(MSBuildThisFileDirectory)SimplifyInterpolation\AbstractSimplifyInterpolationCodeFixProvider.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)SimplifyLinqExpression\SimplifyLinqExpressionCodeFixProvider.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)UpgradeProject\AbstractUpgradeProjectCodeFixProvider.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)UseAutoProperty\AbstractUseAutoPropertyCodeFixProvider.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)UseAutoProperty\UseAutoPropertyFixAllProvider.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\AbstractUseCoalesceExpressionForIfNullStatementCheckCodeFixProvider.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\UseCoalesceExpressionForTernaryConditionalCheckCodeFixProvider.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\UseCoalesceExpressionForNullableTernaryConditionalCheckCodeFixProvider.cs" />

src/Analyzers/CSharp/Tests/UseAutoProperty/UseAutoPropertyTests.cs

@@ -79,15 +79,15 @@ private async Task<Document> FixOneAsync(CodeFixContext context, Diagnostic diag
             text.Lines[diagnosticLinePositionSpan.Start.Line].Start,
             text.Lines[diagnosticLinePositionSpan.End.Line].End);
 
-        var formattingOptions = await context.Document.GetSyntaxFormattingOptionsAsync(SyntaxFormatting, cancellationToken).ConfigureAwait(false);
+        var formattingOptions = await context.Document.GetSyntaxFormattingOptionsAsync(cancellationToken).ConfigureAwait(false);
         var formattedRoot = SyntaxFormatting.GetFormattingResult(root, [spanToFormat], formattingOptions, rules: default, cancellationToken: cancellationToken).GetFormattedRoot(cancellationToken);
 
         return context.Document.WithSyntaxRoot(formattedRoot);
     }
 
     protected override async Task FixAllAsync(Document document, ImmutableArray<Diagnostic> diagnostics, SyntaxEditor editor, CancellationToken cancellationToken)
     {
-        var formattingOptions = await document.GetSyntaxFormattingOptionsAsync(SyntaxFormatting, cancellationToken).ConfigureAwait(false);
+        var formattingOptions = await document.GetSyntaxFormattingOptionsAsync(cancellationToken).ConfigureAwait(false);
         var updatedRoot = SyntaxFormatting.GetFormattingResult(editor.OriginalRoot, [editor.OriginalRoot.FullSpan], formattingOptions, rules: default, cancellationToken).GetFormattedRoot(cancellationToken);
         editor.ReplaceNode(editor.OriginalRoot, updatedRoot);
     }

src/Analyzers/Core/CodeFixes/CodeFixes.projitems

@@ -28,7 +28,6 @@ internal abstract partial class AbstractImplementInterfaceService<TTypeDeclarati
 {
     protected const string DisposingName = "disposing";
 
-    protected abstract ISyntaxFormatting SyntaxFormatting { get; }
     protected abstract SyntaxGeneratorInternal SyntaxGeneratorInternal { get; }
 
     protected abstract string ToDisplayString(IMethodSymbol disposeImplMethod, SymbolDisplayFormat format);