Skip to content

Commit 82d46ca

Browse files
authored
Merge pull request #45840 from allisonchou/ChangeSignatureAccessibility2
Change signature accessibility - add screenreader header for empty column
2 parents 9dd7c7d + a957f39 commit 82d46ca

16 files changed

+74
-0
lines changed

src/VisualStudio/Core/Def/Implementation/ChangeSignature/ChangeSignatureDialog.xaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,11 @@
203203
<!-- This column appears empty to sighted users, but provides an improved screenreader
204204
experience that avoids moving cell-by-cell through the DataGrid -->
205205
<DataGridTextColumn x:Name="automationHeader" IsReadOnly="True" Width="0">
206+
<DataGridTextColumn.HeaderStyle>
207+
<Style TargetType="{x:Type DataGridColumnHeader}">
208+
<Setter Property="AutomationProperties.Name" Value="{Binding ElementName=dialog, Path=CurrentParameter}" />
209+
</Style>
210+
</DataGridTextColumn.HeaderStyle>
206211
<DataGridTextColumn.CellStyle>
207212
<Style TargetType="DataGridCell" BasedOn="{StaticResource DataGridCellStyle}">
208213
<Setter Property="AutomationProperties.Name" Value="{Binding FullAutomationText}"/>

src/VisualStudio/Core/Def/Implementation/ChangeSignature/ChangeSignatureDialog.xaml.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ internal partial class ChangeSignatureDialog : DialogWindow
2222

2323
// Expose localized strings for binding
2424
public string ChangeSignatureDialogTitle { get { return ServicesVSResources.Change_Signature; } }
25+
public string CurrentParameter { get { return ServicesVSResources.Current_parameter; } }
2526
public string Parameters { get { return ServicesVSResources.Parameters_colon2; } }
2627
public string PreviewMethodSignature { get { return ServicesVSResources.Preview_method_signature_colon; } }
2728
public string PreviewReferenceChanges { get { return ServicesVSResources.Preview_reference_changes; } }

src/VisualStudio/Core/Def/ServicesVSResources.resx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1529,4 +1529,7 @@ I agree to all of the foregoing:</value>
15291529
<data name="Warning_colon_type_does_not_bind" xml:space="preserve">
15301530
<value>Warning: type does not bind</value>
15311531
</data>
1532+
<data name="Current_parameter" xml:space="preserve">
1533+
<value>Current parameter</value>
1534+
</data>
15321535
</root>

src/VisualStudio/Core/Def/xlf/ServicesVSResources.cs.xlf

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,11 @@
157157
<target state="translated">Aktuální dokument</target>
158158
<note />
159159
</trans-unit>
160+
<trans-unit id="Current_parameter">
161+
<source>Current parameter</source>
162+
<target state="new">Current parameter</target>
163+
<note />
164+
</trans-unit>
160165
<trans-unit id="Edit">
161166
<source>_Edit</source>
162167
<target state="new">_Edit</target>

src/VisualStudio/Core/Def/xlf/ServicesVSResources.de.xlf

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,11 @@
157157
<target state="translated">Aktuelles Dokument</target>
158158
<note />
159159
</trans-unit>
160+
<trans-unit id="Current_parameter">
161+
<source>Current parameter</source>
162+
<target state="new">Current parameter</target>
163+
<note />
164+
</trans-unit>
160165
<trans-unit id="Edit">
161166
<source>_Edit</source>
162167
<target state="new">_Edit</target>

src/VisualStudio/Core/Def/xlf/ServicesVSResources.es.xlf

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,11 @@
157157
<target state="translated">Documento actual</target>
158158
<note />
159159
</trans-unit>
160+
<trans-unit id="Current_parameter">
161+
<source>Current parameter</source>
162+
<target state="new">Current parameter</target>
163+
<note />
164+
</trans-unit>
160165
<trans-unit id="Edit">
161166
<source>_Edit</source>
162167
<target state="new">_Edit</target>

src/VisualStudio/Core/Def/xlf/ServicesVSResources.fr.xlf

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,11 @@
157157
<target state="translated">Document en cours</target>
158158
<note />
159159
</trans-unit>
160+
<trans-unit id="Current_parameter">
161+
<source>Current parameter</source>
162+
<target state="new">Current parameter</target>
163+
<note />
164+
</trans-unit>
160165
<trans-unit id="Edit">
161166
<source>_Edit</source>
162167
<target state="new">_Edit</target>

src/VisualStudio/Core/Def/xlf/ServicesVSResources.it.xlf

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,11 @@
157157
<target state="translated">Documento corrente</target>
158158
<note />
159159
</trans-unit>
160+
<trans-unit id="Current_parameter">
161+
<source>Current parameter</source>
162+
<target state="new">Current parameter</target>
163+
<note />
164+
</trans-unit>
160165
<trans-unit id="Edit">
161166
<source>_Edit</source>
162167
<target state="new">_Edit</target>

src/VisualStudio/Core/Def/xlf/ServicesVSResources.ja.xlf

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,11 @@
157157
<target state="translated">現在のドキュメント</target>
158158
<note />
159159
</trans-unit>
160+
<trans-unit id="Current_parameter">
161+
<source>Current parameter</source>
162+
<target state="new">Current parameter</target>
163+
<note />
164+
</trans-unit>
160165
<trans-unit id="Edit">
161166
<source>_Edit</source>
162167
<target state="new">_Edit</target>

src/VisualStudio/Core/Def/xlf/ServicesVSResources.ko.xlf

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,11 @@
157157
<target state="translated">현재 문서</target>
158158
<note />
159159
</trans-unit>
160+
<trans-unit id="Current_parameter">
161+
<source>Current parameter</source>
162+
<target state="new">Current parameter</target>
163+
<note />
164+
</trans-unit>
160165
<trans-unit id="Edit">
161166
<source>_Edit</source>
162167
<target state="new">_Edit</target>

0 commit comments

Comments
 (0)