Improve performance of fix all that only changes syntax (#79108)

Author: CyrusNajmabadi

src/Analyzers/Core/CodeFixes/Formatting/FormattingCodeFixProvider.cs

@@ -30,6 +30,14 @@ public sealed override ImmutableArray<string> FixableDiagnosticIds
 
     protected abstract ISyntaxFormatting SyntaxFormatting { get; }
 
+#if WORKSPACE
+    /// <summary>
+    /// This refactoring provider touches syntax only.  So we can speed up fix all by having it only clean syntax
+    /// and not semantics.
+    /// </summary>
+    protected override CodeActionCleanup Cleanup => CodeActionCleanup.SyntaxOnly;
+#endif
+
     /// <summary>
     /// Fixing formatting is high priority.  It's something the user wants to be able to fix quickly, is driven by
     /// them acting on an error reported in code, and can be computed fast as it only uses syntax not semantics.

src/Analyzers/Core/CodeFixes/UpgradeProject/AbstractUpgradeProjectCodeFixProvider.cs

@@ -125,7 +125,7 @@ internal sealed class ProjectOptionsChangeAction : SolutionChangeAction
     public override ImmutableArray<string> Tags => RequiresNonDocumentChangeTags;
 
     private ProjectOptionsChangeAction(string title, Func<IProgress<CodeAnalysisProgress>, CancellationToken, Task<Solution>> createChangedSolution)
-        : base(title, createChangedSolution, equivalenceKey: null, priority: CodeActionPriority.Default, createdFromFactoryMethod: true)
+        : base(title, createChangedSolution, equivalenceKey: null, priority: CodeActionPriority.Default, CodeActionCleanup.Default, createdFromFactoryMethod: true)
     {
     }
 

src/EditorFeatures/Core/Suggestions/FixAll/FixMultipleOccurrencesService.cs

@@ -9,6 +9,7 @@
 using System.Composition;
 using System.Threading;
 using System.Threading.Tasks;
+using Microsoft.CodeAnalysis.CodeActions;
 using Microsoft.CodeAnalysis.CodeFixes;
 using Microsoft.CodeAnalysis.Extensions;
 using Microsoft.CodeAnalysis.Host.Mef;
@@ -67,16 +68,14 @@ private static async Task<Solution> GetFixedSolutionAsync(
         IProgress<CodeAnalysisProgress> progress,
         CancellationToken cancellationToken)
     {
-        var fixMultipleCodeAction = new FixMultipleCodeAction(
-            fixAllState, title, waitDialogMessage);
+        var fixMultipleCodeAction = new FixMultipleCodeAction(fixAllState, title, waitDialogMessage);
 
         Solution newSolution = null;
         var extensionManager = workspace.Services.GetService<IExtensionManager>();
         await extensionManager.PerformActionAsync(fixAllState.FixAllProvider, async () =>
         {
-            // We don't need to post process changes here as the inner code action created for Fix multiple code fix already executes.
             newSolution = await fixMultipleCodeAction.GetChangedSolutionInternalAsync(
-                fixAllState.Solution, progress, postProcessChanges: false, cancellationToken).ConfigureAwait(false);
+                fixAllState.Solution, progress, cancellationToken).ConfigureAwait(false);
         }).ConfigureAwait(false);
 
         return newSolution;

src/EditorFeatures/Core/Suggestions/RefineUsingCopilot/RefineUsingCopilotCodeAction.cs

@@ -59,7 +59,7 @@ protected override async Task<ImmutableArray<CodeActionOperation>> ComputeOperat
                 //       Consider if there could be better UX/platform support for such flavored actions
                 //       where clicking on the hyperlink needs to bring up another unrelated UI.
 
-                var newSolution = await originalCodeAction.GetChangedSolutionInternalAsync(originalSolution, progress, cancellationToken: cancellationToken).ConfigureAwait(false);
+                var newSolution = await originalCodeAction.GetChangedSolutionInternalAsync(originalSolution, progress, cancellationToken).ConfigureAwait(false);
                 if (newSolution == null)
                     return [];
 

src/EditorFeatures/Test/CodeFixes/CodeFixServiceTests.cs

@@ -874,7 +874,7 @@ public async Task TestAdditionalDocumentCodeFixAsync()
 
         // Verify code fix application
         var codeAction = txtDocumentCodeFixes.Single(s => s.Fixes.Single().Action.Title == fixer1.Title).Fixes.Single().Action;
-        var solution = await codeAction.GetChangedSolutionInternalAsync(txtDocument.Project.Solution, CodeAnalysisProgress.None);
+        var solution = await codeAction.GetChangedSolutionInternalAsync(txtDocument.Project.Solution, CodeAnalysisProgress.None, CancellationToken.None);
         var changedtxtDocument = solution!.Projects.Single().AdditionalDocuments.Single(t => t.Id == txtDocument.Id);
         Assert.Equal("Additional Document", txtDocument.GetTextSynchronously(CancellationToken.None).ToString());
         Assert.Equal($"Additional Document{fixer1.Title}", changedtxtDocument.GetTextSynchronously(CancellationToken.None).ToString());

src/EditorFeatures/Test/CodeRefactorings/CodeRefactoringServiceTest.cs

@@ -178,7 +178,7 @@ public async Task TestAdditionalDocumentRefactoringAsync()
 
         // Verify code refactoring application
         var codeAction = txtRefactorings.Single(s => s.CodeActions.Single().action.Title == refactoring1.Title).CodeActions.Single().action;
-        var solution = await codeAction.GetChangedSolutionInternalAsync(project.Solution, CodeAnalysisProgress.None);
+        var solution = await codeAction.GetChangedSolutionInternalAsync(project.Solution, CodeAnalysisProgress.None, CancellationToken.None);
         var changedtxtDocument = solution.Projects.Single().AdditionalDocuments.Single(t => t.Id == txtAdditionalDocument.Id);
         Assert.Empty(txtAdditionalDocument.GetTextSynchronously(CancellationToken.None).ToString());
         Assert.Equal(refactoring1.Title, changedtxtDocument.GetTextSynchronously(CancellationToken.None).ToString());
@@ -217,7 +217,7 @@ public async Task TestAnalyzerConfigDocumentRefactoringAsync()
 
         // Verify code refactoring application
         var codeAction = editorConfigRefactorings.Single(s => s.CodeActions.Single().action.Title == refactoring1.Title).CodeActions.Single().action;
-        var solution = await codeAction.GetChangedSolutionInternalAsync(project.Solution, CodeAnalysisProgress.None);
+        var solution = await codeAction.GetChangedSolutionInternalAsync(project.Solution, CodeAnalysisProgress.None, CancellationToken.None);
         var changedEditorConfig = solution.Projects.Single().AnalyzerConfigDocuments.Single(t => t.Id == editorConfig.Id);
         Assert.Empty(editorConfig.GetTextSynchronously(CancellationToken.None).ToString());
         Assert.Equal(refactoring1.Title, changedEditorConfig.GetTextSynchronously(CancellationToken.None).ToString());

src/Features/CSharp/Portable/CodeRefactorings/EnableNullable/EnableNullableCodeRefactoringProvider.FixAllProvider.cs

@@ -57,7 +57,9 @@ private sealed class FixAllCodeAction(Func<CodeActionPurpose, IProgress<CodeAnal
             : CodeAction.SolutionChangeAction(
                 CSharpFeaturesResources.Enable_nullable_reference_types_in_solution,
                 (progress, cancellationToken) => createChangedSolution(CodeActionPurpose.Apply, progress, cancellationToken),
-                nameof(CSharpFeaturesResources.Enable_nullable_reference_types_in_solution))
+                nameof(CSharpFeaturesResources.Enable_nullable_reference_types_in_solution),
+                CodeActionPriority.Default,
+                CodeActionCleanup.Default)
         {
             private readonly Func<CodeActionPurpose, IProgress<CodeAnalysisProgress>, CancellationToken, Task<Solution>> _createChangedSolution = createChangedSolution;
 

src/Features/CSharp/Portable/CodeRefactorings/EnableNullable/EnableNullableCodeRefactoringProvider.cs

@@ -267,7 +267,9 @@ private sealed class CustomCodeAction(
         : CodeAction.SolutionChangeAction(
             CSharpFeaturesResources.Enable_nullable_reference_types_in_project,
             (progress, cancellationToken) => createChangedSolution(CodeActionPurpose.Apply, progress, cancellationToken),
-            nameof(CSharpFeaturesResources.Enable_nullable_reference_types_in_project))
+            nameof(CSharpFeaturesResources.Enable_nullable_reference_types_in_project),
+            CodeActionPriority.Default,
+            CodeActionCleanup.Default)
     {
         private readonly Func<CodeActionPurpose, IProgress<CodeAnalysisProgress>, CancellationToken, Task<Solution>> _createChangedSolution = createChangedSolution;
 

src/Features/Core/Portable/AddConstructorParametersFromMembers/AddConstructorParametersFromMembersCodeRefactoringProvider.cs

@@ -17,7 +17,6 @@
 using Microsoft.CodeAnalysis.Internal.Log;
 using Microsoft.CodeAnalysis.PooledObjects;
 using Microsoft.CodeAnalysis.Text;
-using Roslyn.Utilities;
 
 namespace Microsoft.CodeAnalysis.AddConstructorParametersFromMembers;
 
@@ -183,7 +182,7 @@ public async Task<ImmutableArray<IntentProcessorResult>> ComputeIntentAsync(
         {
             // Intents currently have no way to report progress.
             var changedSolution = await action.GetChangedSolutionInternalAsync(
-                priorDocument.Project.Solution, CodeAnalysisProgress.None, postProcessChanges: true, cancellationToken).ConfigureAwait(false);
+                priorDocument.Project.Solution, CodeAnalysisProgress.None, cancellationToken).ConfigureAwait(false);
             Contract.ThrowIfNull(changedSolution);
             var intent = new IntentProcessorResult(changedSolution, [priorDocument.Id], action.Title, action.ActionName);
             results.Add(intent);

src/Features/Core/Portable/CodeFixes/FixAllOccurrences/FixMultipleCodeAction.cs

@@ -11,10 +11,7 @@ internal sealed partial class FixMultipleCodeAction(
     string title,
     string computingFixWaitDialogMessage) : AbstractFixAllCodeFixCodeAction(fixAllState, showPreviewChangesDialog: false)
 {
-    private readonly string _title = title;
-    private readonly string _computingFixWaitDialogMessage = computingFixWaitDialogMessage;
+    public override string Title => title;
 
-    public override string Title => _title;
-
-    internal override string Message => _computingFixWaitDialogMessage;
+    internal override string Message => computingFixWaitDialogMessage;
 }