Extensions: update xml docs to new metadata design

Author: Julien Couvreur

src/Compilers/CSharp/Portable/Binder/Semantics/Operators/UnaryOperatorOverloadResolution.cs

@@ -262,9 +262,9 @@ public bool Equals(MethodSymbol? x, MethodSymbol? y)
                 }
 
                 var xExtension = x.OriginalDefinition.ContainingType;
-                var xGroupingKey = ((SourceNamedTypeSymbol)xExtension).GetExtensionGroupingMetadataName();
+                var xGroupingKey = ((SourceNamedTypeSymbol)xExtension).ExtensionGroupingName;
                 var yExtension = y.OriginalDefinition.ContainingType;
-                var yGroupingKey = ((SourceNamedTypeSymbol)yExtension).GetExtensionGroupingMetadataName();
+                var yGroupingKey = ((SourceNamedTypeSymbol)yExtension).ExtensionGroupingName;
 
                 if (!xGroupingKey.Equals(yGroupingKey))
                 {
@@ -293,7 +293,7 @@ public int GetHashCode(MethodSymbol op)
                 int result = typeComparer.GetHashCode(op.OriginalDefinition.ContainingType.ContainingType);
 
                 var extension = op.OriginalDefinition.ContainingType;
-                var groupingKey = ((SourceNamedTypeSymbol)extension).GetExtensionGroupingMetadataName();
+                var groupingKey = ((SourceNamedTypeSymbol)extension).ExtensionGroupingName;
                 result = Hash.Combine(result, groupingKey.GetHashCode());
 
                 foreach (var parameter in op.OriginalDefinition.AsMember(Normalize(extension)).Parameters)

src/Compilers/CSharp/Portable/Compiler/DocumentationCommentCompiler.cs

@@ -175,15 +175,14 @@ public override object VisitTypeParameter(TypeParameterSymbol symbol, StringBuil
 
             public override object VisitNamedType(NamedTypeSymbol symbol, StringBuilder builder)
             {
-                if ((object)symbol.ContainingSymbol != null && symbol.ContainingSymbol.Name.Length != 0)
+                Symbol containingSymbol = symbol.ContainingSymbol;
+                if ((object)containingSymbol != null && (containingSymbol.Name.Length != 0 || containingSymbol is NamedTypeSymbol { IsExtension: true }))
                 {
-                    Visit(symbol.ContainingSymbol, builder);
+                    Visit(containingSymbol, builder);
                     builder.Append('.');
                 }
 
-                // PROTOTYPE: Finalize the doc ID story. When we refer to a member, we probably need to use grouping type name,
-                //            but when we refer to an extension block, we probably need to "dot" through both names. 
-                builder.Append(symbol.IsExtension ? symbol.ExtensionName : symbol.Name);
+                builder.Append(symbol.IsExtension ? symbol.ExtensionGroupingName : symbol.Name);
 
                 if (symbol.Arity != 0)
                 {

src/Compilers/CSharp/Portable/DocumentationComments/DocumentationCommentIDVisitor.PartVisitor.cs

@@ -70,6 +70,11 @@ public override object VisitNamedType(NamedTypeSymbol symbol, StringBuilder buil
         {
             builder.Append("T:");
             PartVisitor.Instance.Visit(symbol, builder);
+            if (symbol.IsExtension)
+            {
+                builder.Append('.');
+                builder.Append(symbol.ExtensionMarkerName);
+            }
 
             return null;
         }

src/Compilers/CSharp/Portable/DocumentationComments/DocumentationCommentIDVisitor.cs

@@ -310,7 +310,7 @@ Cci.ITypeDefinition Cci.ITypeDefinitionMember.ContainingTypeDefinition
                     return synthesizedGlobalMethod.ContainingPrivateImplementationDetailsType;
                 }
 
-                // PROTOTYPE: Share logic with Cci.ITypeMemberReference.GetContainingType implementation?
+                // Tracked by https://github.com/dotnet/roslyn/issues/78827 : code quality, share logic with Cci.ITypeMemberReference.GetContainingType implementation?
                 if (AdaptedMethodSymbol is SynthesizedExtensionMarker marker)
                 {
                     return ((SourceMemberContainerTypeSymbol)AdaptedMethodSymbol.ContainingType.ContainingType).GetExtensionGroupingInfo().GetCorrespondingMarkerType(marker);

src/Compilers/CSharp/Portable/Emitter/Model/MethodSymbolAdapter.cs

@@ -221,7 +221,7 @@ ITypeDefinition ITypeDefinitionMember.ContainingTypeDefinition
             {
                 CheckDefinitionInvariant();
 
-                // PROTOTYPE: Share logic with Cci.ITypeMemberReference.GetContainingType implementation?
+                // Tracked by https://github.com/dotnet/roslyn/issues/78827 : code quality, share logic with Cci.ITypeMemberReference.GetContainingType implementation?
                 if (AdaptedPropertySymbol.GetIsNewExtensionMember())
                 {
                     var containingType = AdaptedPropertySymbol.ContainingType;
@@ -249,7 +249,7 @@ ITypeReference ITypeMemberReference.GetContainingType(EmitContext context)
         {
             CheckDefinitionInvariant();
 
-            // PROTOTYPE: Share logic with Cci.ITypeMemberReference.GetContainingType implementation in MethodSymbolAdapter?
+            // Tracked by https://github.com/dotnet/roslyn/issues/78827 : code quality, share logic with Cci.ITypeMemberReference.GetContainingType implementation in MethodSymbolAdapter?
             if (AdaptedPropertySymbol.GetIsNewExtensionMember())
             {
                 var containingType = AdaptedPropertySymbol.ContainingType;

src/Compilers/CSharp/Portable/Emitter/Model/PropertySymbolAdapter.cs

@@ -346,7 +346,7 @@ private void AddNameAndTypeArgumentsOrParameters(INamedTypeSymbol symbol)
                 if (Format.CompilerInternalOptions.HasFlag(SymbolDisplayCompilerInternalOptions.UseMetadataMemberNames))
                 {
                     // PROTOTYPE: What should we output as the name here
-                    var extensionIdentifier = underlyingTypeSymbol!.ExtensionName; // Tracked by https://github.com/dotnet/roslyn/issues/78957 : public API, use public API once it's available
+                    var extensionIdentifier = underlyingTypeSymbol!.ExtensionGroupingName; // Tracked by https://github.com/dotnet/roslyn/issues/78957 : public API, use public API once it's available
                     Builder.Add(CreatePart(SymbolDisplayPartKind.ClassName, symbol, extensionIdentifier));
                 }
                 else

src/Compilers/CSharp/Portable/SymbolDisplay/SymbolDisplayVisitor.Types.cs

@@ -82,7 +82,10 @@ internal sealed override bool MangleName
             internal sealed override bool IsFileLocal => false;
             internal sealed override FileIdentifier? AssociatedFileIdentifier => null;
 
-            internal override string ExtensionName
+            internal override string ExtensionGroupingName
+                => throw ExceptionUtilities.Unreachable();
+
+            internal override string ExtensionMarkerName
                 => throw ExceptionUtilities.Unreachable();
 
             public sealed override int Arity

src/Compilers/CSharp/Portable/Symbols/AnonymousTypes/PublicSymbols/AnonymousManager.TypeOrDelegatePublicSymbol.cs

@@ -167,7 +167,10 @@ public sealed override bool IsRefLikeType
                 get { return false; }
             }
 
-            internal override string ExtensionName
+            internal override string ExtensionGroupingName
+                => throw ExceptionUtilities.Unreachable();
+
+            internal override string ExtensionMarkerName
                 => throw ExceptionUtilities.Unreachable();
 
             public sealed override bool IsReadOnly

src/Compilers/CSharp/Portable/Symbols/AnonymousTypes/SynthesizedSymbols/AnonymousType.TypeOrDelegateTemplateSymbol.cs

@@ -116,7 +116,10 @@ public sealed override bool IsRefLikeType
             }
         }
 
-        internal override string ExtensionName
+        internal sealed override string ExtensionGroupingName
+            => throw ExceptionUtilities.Unreachable();
+
+        internal sealed override string ExtensionMarkerName
             => throw ExceptionUtilities.Unreachable();
 
         public sealed override bool IsReadOnly