Skip to content

Commit df0a580

Browse files
author
msftbot[bot]
authored
Merge pull request #46211 from tmat/IHBuildFix
Fix InteractiveHost32 build
2 parents 0c48c30 + fc309fc commit df0a580

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

src/Interactive/HostTest/InteractiveHost.UnitTests.csproj

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,13 @@
2424
<!--
2525
Not using ProjectReference since it does not execute the specified targets when building in VS.
2626
See https://github.com/microsoft/msbuild/issues/5434.
27+
28+
Note: do not set TargetFramework=net472 for InteractiveHost32. The project is not multi-targeted.
29+
Setting the property would create a build configuration that's different from the one the solution uses
30+
and thus would result in building the project twice.
2731
-->
2832

2933
<CopyPublishedOutputProjectReference Include="..\HostProcess\InteractiveHost32.csproj">
30-
<SetTargetFramework>TargetFramework=net472</SetTargetFramework>
3134
<OutputItemType>InteractiveHostFiles_Desktop32</OutputItemType>
3235
</CopyPublishedOutputProjectReference>
3336

src/VisualStudio/Setup/Roslyn.VisualStudio.Setup.csproj

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -295,8 +295,11 @@
295295
<ProjectReference Include="..\..\Interactive\HostProcess\InteractiveHost32.csproj">
296296
<Name>InteractiveHost.Desktop32</Name>
297297

298-
<SetTargetFramework>TargetFramework=net472</SetTargetFramework>
299-
<SkipGetTargetFrameworkProperties>true</SkipGetTargetFrameworkProperties>
298+
<!--
299+
Note: do not set TargetFramework=net472 for InteractiveHost32. The project is not multi-targeted.
300+
Setting the property would create a build configuration that's different from the one the solution uses
301+
and thus would result in building the project twice.
302+
-->
300303
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
301304

302305
<Private>false</Private>

0 commit comments

Comments
 (0)