Merge pull request #43100 from sharwell/is-match

sharwell · web-flow · commit e768297443d8 · 2020-04-06T19:09:17.000-07:00
🐇 Use Regex.IsMatch instead of Regex.Match when no groups are needed
diff --git a/src/Compilers/Core/Portable/CommandLine/AnalyzerConfig.SectionNameMatching.cs b/src/Compilers/Core/Portable/CommandLine/AnalyzerConfig.SectionNameMatching.cs
@@ -31,6 +31,11 @@ internal SectionNameMatcher(
 
             public bool IsMatch(string s)
             {
+                if (_numberRangePairs.IsEmpty)
+                {
+                    return Regex.IsMatch(s);
+                }
+
                 var match = Regex.Match(s);
                 if (!match.Success)
                 {

Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,11 @@ internal SectionNameMatcher(`
`31`	`31`
`32`	`32`	`public bool IsMatch(string s)`
`33`	`33`	`{`
	`34`	`+ if (_numberRangePairs.IsEmpty)`
	`35`	`+ {`
	`36`	`+ return Regex.IsMatch(s);`
	`37`	`+ }`
	`38`	`+`
`34`	`39`	`var match = Regex.Match(s);`
`35`	`40`	`if (!match.Success)`
`36`	`41`	`{`