From ecfd5b1300540f2aac99530536118ffa4affc83a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Matou=C5=A1ek?= Date: Thu, 10 Feb 2022 19:55:35 -0800 Subject: [PATCH] Remove dependency on EditorFeatures from Remote.ServieHub project - take 3 (#59316) * Revert "Revert "Remove dependency on EditorFeatures from Remote.ServiceHub project - take 2 (#59147)" (#59242)" This reverts commit 8d81aa51ec316d6a545cbc1a0afebad320444d7b. * Move GoToBaseService to Features * Remove unnecessray PackageRefs * Fixes --- eng/targets/Services.props | 2 +- .../CSharpDecompiledSourceService.cs | 2 +- .../FindUsages/CSharpFindUsagesLSPService.cs | 5 +- .../FindUsages/CSharpFindUsagesService.cs | 2 +- .../CSharp/GoToBase/CSharpGoToBaseService.cs | 4 +- .../FindBaseSymbolsCommandHandler.cs | 2 +- .../FindDerivedSymbolsCommandHandler.cs | 2 +- .../FindExtensionMethodsCommandHandler.cs | 2 +- .../FindImplementingMembersCommandHandler.cs | 1 - .../FindMemberOverloadsCommandHandler.cs | 2 +- ...FindReferencesOfOverloadsCommandHandler.cs | 2 +- .../Core.Wpf/Peek/PeekableItemFactory.cs | 3 +- .../Core/EditorFeaturesResources.resx | 15 --- .../VSTypeScriptFindUsagesService.cs | 1 - .../FindReferencesCommandHandler.cs | 1 - .../FindUsages/SimpleFindUsagesContext.cs | 10 +- .../Core/GoToBase/GoToBaseCommandHandler.cs | 3 +- .../AbstractGoToDefinitionService.cs | 1 - .../GoToDefinitionCommandHandler.cs | 2 +- .../GoToDefinition/GoToDefinitionHelpers.cs | 1 - .../GoToImplementationCommandHandler.cs | 1 - ...lassificationTaggerProvider.TagComputer.cs | 2 +- .../DefinitionContextTracker.cs | 2 +- .../References/FindAllReferencesHandler.cs | 1 - .../References/FindImplementationsHandler.cs | 1 - .../References/FindUsagesLSPContext.cs | 6 +- .../NavigationBar/NavigationBarController.cs | 4 +- ...crosoft.CodeAnalysis.EditorFeatures.csproj | 2 - .../Tagging/EventSources/TaggerConstants.cs | 16 +-- .../SymbolSearchUpdateEngineFactory.cs | 114 ------------------ .../CompilationAvailableTaggerEventSource.cs | 11 +- .../Core/xlf/EditorFeaturesResources.cs.xlf | 35 +----- .../Core/xlf/EditorFeaturesResources.de.xlf | 35 +----- .../Core/xlf/EditorFeaturesResources.es.xlf | 35 +----- .../Core/xlf/EditorFeaturesResources.fr.xlf | 35 +----- .../Core/xlf/EditorFeaturesResources.it.xlf | 35 +----- .../Core/xlf/EditorFeaturesResources.ja.xlf | 35 +----- .../Core/xlf/EditorFeaturesResources.ko.xlf | 35 +----- .../Core/xlf/EditorFeaturesResources.pl.xlf | 35 +----- .../xlf/EditorFeaturesResources.pt-BR.xlf | 35 +----- .../Core/xlf/EditorFeaturesResources.ru.xlf | 35 +----- .../Core/xlf/EditorFeaturesResources.tr.xlf | 35 +----- .../xlf/EditorFeaturesResources.zh-Hans.xlf | 35 +----- .../xlf/EditorFeaturesResources.zh-Hant.xlf | 35 +----- .../FindReferencesCommandHandlerTests.cs | 8 +- .../StackTraceExplorerTests.cs | 2 +- .../FindReferencesCommandHandlerTests.vb | 2 +- .../FindReferences/FindReferencesTests.vb | 10 +- .../Test2/GoToBase/GoToBaseTestsBase.vb | 4 +- .../Test2/GoToHelpers/GoToHelpers.vb | 2 +- .../GoToImplementationTests.vb | 2 +- .../MockNavigableItemsPresenter.vb | 1 - .../VisualBasicFindUsagesLSPService.vb | 3 +- .../VisualBasicFindUsagesService.vb | 2 +- .../GoToBase/VisualBasicGoToBaseService.vb | 4 +- .../Core/Portable/Common/DelayTimeSpan.cs | 17 +++ .../Core/Portable/FeaturesResources.resx | 18 +++ ...UsagesService.DefinitionTrackingContext.cs | 2 +- ...stractFindUsagesService.ProgressAdapter.cs | 2 +- .../FindUsages/AbstractFindUsagesService.cs | 4 +- ...ctFindUsagesService_FindImplementations.cs | 8 +- ...bstractFindUsagesService_FindReferences.cs | 6 +- .../Core/Portable/FindUsages/ExternalScope.cs | 2 - .../Portable}/FindUsages/FindUsagesContext.cs | 8 +- .../Portable/FindUsages/FindUsagesHelpers.cs | 2 +- .../Portable/FindUsages/FindUsagesOptions.cs | 10 +- .../IDefinitionsAndReferencesFactory.cs | 3 +- .../FindUsages/IFindUsagesLSPService.cs | 2 +- .../FindUsages/IFindUsagesService.cs | 2 +- .../GoToBase/AbstractGoToBaseService.cs | 9 +- .../Portable}/GoToBase/FindBaseHelpers.cs | 2 +- .../Portable}/GoToBase/IGoToBaseService.cs | 2 +- .../AbstractFindDefinitionService.cs | 2 +- .../InheritanceMarginServiceHelpers.cs | 1 - .../Microsoft.CodeAnalysis.Features.csproj | 8 +- .../AbstractStackTraceSymbolResolver.cs | 5 +- .../StackFrameLocalMethodResolver.cs | 2 +- .../StackFrameMethodSymbolResolver.cs | 2 +- .../StackTraceExplorerOptions.cs | 21 ---- .../StackTraceExplorerService.cs | 3 +- .../StackTraceExplorerUtilities.cs | 4 +- .../SymbolSearchUpdateEngineFactory.cs | 26 ++++ .../SymbolSearchUpdateNoOpEngine.cs | 28 +++++ .../Windows}/IAddReferenceDatabaseWrapper.cs | 0 .../Windows}/IDatabaseFactoryService.cs | 0 .../SymbolSearch/Windows}/IDelayService.cs | 0 .../SymbolSearch/Windows}/IIOService.cs | 0 .../SymbolSearch/Windows}/IPatchService.cs | 0 .../Windows}/IRemoteControlService.cs | 0 .../SymbolSearch/Windows/NativePatching.cs} | 6 +- ...archUpdateEngine.DatabaseFactoryService.cs | 0 .../SymbolSearchUpdateEngine.DelayService.cs | 0 .../SymbolSearchUpdateEngine.IOService.cs | 0 .../SymbolSearchUpdateEngine.PatchService.cs | 2 +- ...SearchUpdateEngine.RemoteControlService.cs | 0 .../SymbolSearchUpdateEngine.Update.cs | 0 .../Windows}/SymbolSearchUpdateEngine.cs | 0 .../SymbolSearchUpdateEngineFactory.cs | 49 ++++++++ .../Windows/SymbolSearchUpdateEngineProxy.cs | 61 ++++++++++ .../Tagging/CompilationAvailableHelpers.cs | 16 +++ .../Portable/xlf/FeaturesResources.cs.xlf | 30 +++++ .../Portable/xlf/FeaturesResources.de.xlf | 30 +++++ .../Portable/xlf/FeaturesResources.es.xlf | 30 +++++ .../Portable/xlf/FeaturesResources.fr.xlf | 30 +++++ .../Portable/xlf/FeaturesResources.it.xlf | 30 +++++ .../Portable/xlf/FeaturesResources.ja.xlf | 30 +++++ .../Portable/xlf/FeaturesResources.ko.xlf | 30 +++++ .../Portable/xlf/FeaturesResources.pl.xlf | 30 +++++ .../Portable/xlf/FeaturesResources.pt-BR.xlf | 30 +++++ .../Portable/xlf/FeaturesResources.ru.xlf | 30 +++++ .../Portable/xlf/FeaturesResources.tr.xlf | 30 +++++ .../xlf/FeaturesResources.zh-Hans.xlf | 30 +++++ .../xlf/FeaturesResources.zh-Hant.xlf | 30 +++++ .../Debugger/DebuggerFindReferencesService.cs | 2 +- .../FindUsages/FSharpFindUsagesService.cs | 1 - .../Options/AdvancedOptionPageControl.xaml.cs | 2 +- ...bstractTableDataSourceFindUsagesContext.cs | 6 +- ...alStudioDefinitionsAndReferencesFactory.cs | 1 - .../AbstractObjectBrowserLibraryManager.cs | 4 +- .../VisualStudioSymbolNavigationService.cs | 1 - .../PdbSourceDocumentOutputWindowLogger.cs | 3 +- .../StackTraceExplorerCommandHandler.cs | 9 +- .../StackTraceExplorerOptions.cs | 35 ++++++ .../Venus/DocumentService_IntegrationTests.vb | 2 +- .../Fakes/StubStreamingFindUsagesPresenter.cs | 1 - .../Remote/InProcRemostHostClient.cs | 2 +- ...soft.CodeAnalysis.Remote.ServiceHub.csproj | 9 +- .../FindUsages/RemoteFindUsagesService.cs | 1 - ...teSemanticClassificationService.Caching.cs | 3 +- .../RemoteStackTraceExplorerService.cs | 4 +- ...RemoteTaggerCompilationAvailableService.cs | 4 +- 131 files changed, 835 insertions(+), 698 deletions(-) delete mode 100644 src/EditorFeatures/Core/SymbolSearch/SymbolSearchUpdateEngineFactory.cs create mode 100644 src/Features/Core/Portable/Common/DelayTimeSpan.cs rename src/{EditorFeatures/Core => Features/Core/Portable}/FindUsages/AbstractFindUsagesService.DefinitionTrackingContext.cs (98%) rename src/{EditorFeatures/Core => Features/Core/Portable}/FindUsages/AbstractFindUsagesService.ProgressAdapter.cs (99%) rename src/{EditorFeatures/Core => Features/Core/Portable}/FindUsages/AbstractFindUsagesService.cs (75%) rename src/{EditorFeatures/Core => Features/Core/Portable}/FindUsages/AbstractFindUsagesService_FindImplementations.cs (96%) rename src/{EditorFeatures/Core => Features/Core/Portable}/FindUsages/AbstractFindUsagesService_FindReferences.cs (98%) rename src/{EditorFeatures/Core => Features/Core/Portable}/FindUsages/FindUsagesContext.cs (79%) rename src/{EditorFeatures/Core => Features/Core/Portable}/FindUsages/IDefinitionsAndReferencesFactory.cs (99%) rename src/{EditorFeatures/Core => Features/Core/Portable}/FindUsages/IFindUsagesLSPService.cs (95%) rename src/{EditorFeatures/Core => Features/Core/Portable}/FindUsages/IFindUsagesService.cs (95%) rename src/{EditorFeatures/Core => Features/Core/Portable}/GoToBase/AbstractGoToBaseService.cs (87%) rename src/{EditorFeatures/Core => Features/Core/Portable}/GoToBase/FindBaseHelpers.cs (96%) rename src/{EditorFeatures/Core => Features/Core/Portable}/GoToBase/IGoToBaseService.cs (93%) rename src/{EditorFeatures/Core => Features/Core/Portable}/InheritanceMargin/InheritanceMarginServiceHelpers.cs (99%) rename src/{EditorFeatures/Core => Features/Core/Portable}/StackTraceExplorer/AbstractStackTraceSymbolResolver.cs (95%) rename src/{EditorFeatures/Core => Features/Core/Portable}/StackTraceExplorer/StackFrameLocalMethodResolver.cs (96%) rename src/{EditorFeatures/Core => Features/Core/Portable}/StackTraceExplorer/StackFrameMethodSymbolResolver.cs (95%) delete mode 100644 src/Features/Core/Portable/StackTraceExplorer/StackTraceExplorerOptions.cs rename src/{EditorFeatures/Core => Features/Core/Portable}/StackTraceExplorer/StackTraceExplorerService.cs (97%) rename src/{EditorFeatures/Core => Features/Core/Portable}/StackTraceExplorer/StackTraceExplorerUtilities.cs (97%) create mode 100644 src/Features/Core/Portable/SymbolSearch/SourceBuild/SymbolSearchUpdateEngineFactory.cs create mode 100644 src/Features/Core/Portable/SymbolSearch/SymbolSearchUpdateNoOpEngine.cs rename src/{EditorFeatures/Core/SymbolSearch => Features/Core/Portable/SymbolSearch/Windows}/IAddReferenceDatabaseWrapper.cs (100%) rename src/{EditorFeatures/Core/SymbolSearch => Features/Core/Portable/SymbolSearch/Windows}/IDatabaseFactoryService.cs (100%) rename src/{EditorFeatures/Core/SymbolSearch => Features/Core/Portable/SymbolSearch/Windows}/IDelayService.cs (100%) rename src/{EditorFeatures/Core/SymbolSearch => Features/Core/Portable/SymbolSearch/Windows}/IIOService.cs (100%) rename src/{EditorFeatures/Core/SymbolSearch => Features/Core/Portable/SymbolSearch/Windows}/IPatchService.cs (100%) rename src/{EditorFeatures/Core/SymbolSearch => Features/Core/Portable/SymbolSearch/Windows}/IRemoteControlService.cs (100%) rename src/{EditorFeatures/Core/SymbolSearch/Patching/Delta.cs => Features/Core/Portable/SymbolSearch/Windows/NativePatching.cs} (94%) rename src/{EditorFeatures/Core/SymbolSearch => Features/Core/Portable/SymbolSearch/Windows}/SymbolSearchUpdateEngine.DatabaseFactoryService.cs (100%) rename src/{EditorFeatures/Core/SymbolSearch => Features/Core/Portable/SymbolSearch/Windows}/SymbolSearchUpdateEngine.DelayService.cs (100%) rename src/{EditorFeatures/Core/SymbolSearch => Features/Core/Portable/SymbolSearch/Windows}/SymbolSearchUpdateEngine.IOService.cs (100%) rename src/{EditorFeatures/Core/SymbolSearch => Features/Core/Portable/SymbolSearch/Windows}/SymbolSearchUpdateEngine.PatchService.cs (88%) rename src/{EditorFeatures/Core/SymbolSearch => Features/Core/Portable/SymbolSearch/Windows}/SymbolSearchUpdateEngine.RemoteControlService.cs (100%) rename src/{EditorFeatures/Core/SymbolSearch => Features/Core/Portable/SymbolSearch/Windows}/SymbolSearchUpdateEngine.Update.cs (100%) rename src/{EditorFeatures/Core/SymbolSearch => Features/Core/Portable/SymbolSearch/Windows}/SymbolSearchUpdateEngine.cs (100%) create mode 100644 src/Features/Core/Portable/SymbolSearch/Windows/SymbolSearchUpdateEngineFactory.cs create mode 100644 src/Features/Core/Portable/SymbolSearch/Windows/SymbolSearchUpdateEngineProxy.cs create mode 100644 src/Features/Core/Portable/Tagging/CompilationAvailableHelpers.cs create mode 100644 src/VisualStudio/Core/Def/StackTraceExplorer/StackTraceExplorerOptions.cs diff --git a/eng/targets/Services.props b/eng/targets/Services.props index c4421f0d7a042..316192a92ea15 100644 --- a/eng/targets/Services.props +++ b/eng/targets/Services.props @@ -38,7 +38,7 @@ - +