Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BasicEditAndContinue Integration Tests Failing #37689

Closed
3 of 4 tasks
JoeRobich opened this issue Aug 3, 2019 · 1 comment · Fixed by #70635
Closed
3 of 4 tasks

BasicEditAndContinue Integration Tests Failing #37689

JoeRobich opened this issue Aug 3, 2019 · 1 comment · Fixed by #70635
Assignees
@JoeRobich
Labels
Area-Infrastructure Integration-Test Test failures in roslyn-integration-CI

Comments

@JoeRobich
Copy link
Member

JoeRobich commented Aug 3, 2019 •
edited
Loading

A recent update to the preview version of Visual Studio that is used for integration tests has caused Basic EnC tests to consistently fail.

  • Make integration tests not required for PRs
  • Add skips for these tests and flow through
  • Make integration tests required for PRs
  • Unskip these tests when a fix is in place.
@JoeRobich JoeRobich added Area-Infrastructure Test Test failures in roslyn-CI labels Aug 3, 2019
@JoeRobich JoeRobich self-assigned this Aug 3, 2019
@JoeRobich JoeRobich mentioned this issue Aug 3, 2019
Merged
@sharwell sharwell added Integration-Test Test failures in roslyn-integration-CI and removed Test Test failures in roslyn-CI labels Aug 5, 2019
@JoeRobich JoeRobich mentioned this issue Aug 7, 2019
Closed
sharwell added a commit to sharwell/roslyn that referenced this issue Oct 31, 2023
@sharwell
Port edit and continue tests to the new framework
bea6452 
Closes dotnet#35965
Closes dotnet#36763
Closes dotnet#37689
@sharwell sharwell mentioned this issue Oct 31, 2023
Merged
sharwell added a commit to sharwell/roslyn that referenced this issue Nov 3, 2023
@sharwell
Port edit and continue tests to the new framework
e5442be 
Closes dotnet#35965
Closes dotnet#36763
Closes dotnet#37689
@CyrusNajmabadi
Copy link
Member

Amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoeRobich JoeRobich

Labels
Area-Infrastructure Integration-Test Test failures in roslyn-integration-CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Integration fixes sharwell/roslyn
3 participants
@JoeRobich @sharwell @CyrusNajmabadi