Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find all references on a class name display duplicate records #43500

Closed
vsfeedback opened this issue Apr 20, 2020 · 4 comments
Closed

Find all references on a class name display duplicate records #43500

vsfeedback opened this issue Apr 20, 2020 · 4 comments
Labels
Area-IDE Bug help wanted The issue is "up for grabs" - add a comment if you are interested in working on it Regression
Milestone

Comments

@vsfeedback
Copy link

This issue has been moved from a ticket on Developer Community.


Invoke "Find All References" on a class name MyClass in line 10
Result: Line 7 is displayed 3 times, one at position 4 and two identical records at position 22

namespace ConsoleApp1
{
	class Program
	{
		static void Main(string[] args)
		{
			MyClass obj = new MyClass(); // Line #7
		}
	}
	public class MyClass // Line #10 Invoke Find All References here
	{
		public MyClass()
		{
		}
	}
}


Original Comments

Visual Studio Feedback System on 9/25/2019, 01:47 AM:

We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.

Visual Studio Feedback System on 10/7/2019, 00:54 AM:

This issue is currently being investigated. Our team will get back to you if either more information is needed, a workaround is available, or the issue is resolved.

Dean Jackson on 11/22/2019, 06:03 AM:

I have the same problem! (using version 16.3.x). Yes, the same line (like your #7) is listed 3 times in the results. So, If you really do have 8 references, that will be 24 items in the results list!!

Visual Studio Feedback System on 3/31/2020, 05:38 PM:

Thank you for sharing your feedback! Our teams prioritize action on product issues with broad customer impact. See details at: https://docs.microsoft.com/en-us/visualstudio/ide/report-a-problem?view=vs-2019#faq. In case you need answers to common questions or need assisted support, be sure to use https://visualstudio.microsoft.com/vs/support/. We’ll keep you posted on any updates to this feedback.


Original Solutions

(no solutions)

@mavasani
Copy link
Contributor

mavasani commented Apr 20, 2020

Tagging @CyrusNajmabadi - the references are theoretically correct - 2 references to type name and 1 reference to ctor invocation. Do we want to show a single type name reference instead (i.e. do not show it as a type name reference when it is used in context of an object creation expression)?

FAR_Duplicates

@mavasani mavasani added Area-IDE Bug Need Design Review The end user experience design needs to be reviewed and approved. labels Apr 20, 2020
@sharwell
Copy link
Member

This should have been fixed by #34617

@sharwell
Copy link
Member

Here's the intended design:
#34617 (comment)

@sharwell sharwell added Regression help wanted The issue is "up for grabs" - add a comment if you are interested in working on it and removed Need Design Review The end user experience design needs to be reviewed and approved. labels Apr 20, 2020
@jinujoseph jinujoseph added this to the Backlog milestone Apr 28, 2020
@CyrusNajmabadi
Copy link
Member

The current behavior is correct and desirable:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Bug help wanted The issue is "up for grabs" - add a comment if you are interested in working on it Regression
Projects
Archived in project
Development

No branches or pull requests

5 participants