"Add null check" quickfix should support generating ArgumentNullException.ThrowIfNull() calls

[Eli-Black-Work]

The "Add null check" quickfix in Visual Studio doesn't have an option for generating a null check using ArgumentNullException.ThrowIfNull().

Consider the following code:

public string Example(object name)
{
    return name.ToString();
}

The "Add null check" quickfix looks like this:

I'd like for the quickfix to also have an option for generating a call to ArgumentNullException.ThrowIfNull(), so that the resulting code looks like this:

public string Example(object name)
{
    ArgumentNullException.ThrowIfNull(name);

    return name.ToString();
}

[Eli-Black-Work]

This would need to be only available on projects using .NET 6 or above.

[Neme12]

@Bosch-Eli-Black I wouldn't check for the target framework, but rather whether the method exists and has the correct signature.

[Eli-Black-Work]

It's also be sweet if there were a quickfix to convert this:

if (name == null)
        throw new ArgumentNullException(nameof(name));

to this:

ArgumentNullException.ThrowIfNull(name);

(Preferably a quickfix that could be run across all .cs files in the solution 🙂)

[davidwengier]

dotnet/runtime#68326

[Eli-Black-Work]

@davidwengier Oooh, thanks! Guess I was in the wrong repo 🙂 Let me comment over there.

Thanks again! 🙂

[Eli-Black-Work]

@Neme12 Ah, yes, good point; that's probably the proper way to do that 🙂