Porting two recent tuple-related fixes to VB #14518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/roslyn-compiler - please review |
|
@MattGertz - for RC approval. This is mostly just a parity with C#.
|
|
Approved pending tests and signoffs. |
jcouv
reviewed
Oct 14, 2016
| @@ -315,6 +315,8 @@ Namespace Microsoft.CodeAnalysis.VisualBasic | |||
| resultKind = LookupResultKind.NotCreatable | |||
| errorReported = True | |||
|
|
|||
|
|
|||
|
|
|||
| Case TypeKind.Array | |||
|
@dotnet-bot test this please |
|
LGTM |
VSadov
force-pushed
the
portToVb001
branch
4 times, most recently
from
0b0a10f
to
276fb7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14260
== VB counterpart for:
Fixes: #10891 - Forbid constructing tuples via "new"
Fixes: #11689 - Enforce that ValueTuple types are structs
Note that #11689 requires validation that ValueTuple is a value type only in common cases, That is - to convey that cases where ValueTuple happens to be a Class, Enum, Delegate, etc are clearly not supported.
From the language prospective, tuples are value types composed of their elements. That is visible through the semantics of definite assignment, conversions, nullable lifting, async capturing and so on. This change intentionally introduces emit failures when underlying ValueTuple types are not structs.