support CasePatternSwitchLabel in StatementSyntaxComparer #19164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanbasov
requested review from
tmat,
gafter,
CyrusNajmabadi,
jinujoseph and
jcouv
tmat
reviewed
May 11, 2017
| rightNode.Parent != null && | ||
| GetLabel(leftNode.Parent) == GetLabel(rightNode.Parent)) | ||
| { | ||
| parentDistance = ComputeDistance(leftNode.Parent, rightNode.Parent); |
There was a problem hiding this comment.
I think this is a good idea, but wonder if we need to tailor it a bit more to switch case.
In future C# will support complex pattern matching in switch, so the direct parent of a variable designation won't be the case label.
How about find the first containing node that has a label instead of the direct parent?
#Resolved
There was a problem hiding this comment.
Le'ts keep it as is and file an issue to track the generalization. #Resolved
|
👍 |
jinujoseph
approved these changes
May 16, 2017
|
Tagging @MattGertz for ask mode approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer scenario
Variables declared by patterns within switch statements are matched incorrectly by StatementSyntaxComparer. Fixing this. Have to add one more pass for the matcher. It does not affect the performance. However, it would be nice to re-consider this. Created #19163.
Bugs this fixes:
Fixes #18970
Workarounds, if any
Risk
Low
Performance impact
Low
Is this a regression from a previous update?
Root cause analysis:
How did we miss it? What tests are we adding to guard against it in the future?
How was the bug found?
Planned