Test base #19521
Merged
Test base #19521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmat
added
the
PR For Personal Review Only
tmat
added
Test
|
@dotnet/roslyn-compiler Please review -- this is test only change. Recommended to review each commit separately. |
jaredpar
approved these changes
May 15, 2017
|
|
|
@dotnet/roslyn-compiler Anybody else interested in reviewing? |
|
Starting review. |
jcouv
reviewed
May 17, 2017
| private IEnumerable<IModuleSymbol> GetReferencesToModuleSymbols(IEnumerable<MetadataReference> references, MetadataImportOptions importOptions) | ||
| { | ||
| var dummy = _compilation | ||
| .RemoveAllReferences() |
There was a problem hiding this comment.
RemoveAllReferences is just the same as WithReferences with some empty array. What is the benefit of calling WithReferences twice?
jcouv
reviewed
May 17, 2017
|
|
||
| namespace Microsoft.CodeAnalysis.Test.Utilities | ||
| { | ||
| internal sealed class CompilationDifference | ||
| public sealed class CompilationDifference |
There was a problem hiding this comment.
There is no need for it to be internal. Public is easier as it avoids more internals visible to between test assemblies.
|
@jcouv Thanks for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test only change (refactoring).
Currently many test classes across Roslyn compiles and services derive from TestBase. TestBase has become a kitchen sink of helpers. Some of them make sense for all tests, but a lot of them are specific to compilers and are not relevant to services. This change takes a step at separating compiler specific helpers, such as PDB validation to a separate class and project -- Roslyn.Test.PdbUtilities. Long term we could move more IL and metadata validation to this project and rename it to CompilerTestUtilities.