Fix saving naming styles options page #34212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow page controls to store settings to option store before updating service - Reload page control settings after a cancel or save
JoeRobich
commented
Mar 18, 2019
| @@ -12,9 +12,6 @@ | |||
| <TargetLatestRuntimePatch>false</TargetLatestRuntimePatch> | |||
| <SelfContained>true</SelfContained> | |||
|
|
|||
| <!-- Do not build again when publishing --> | |||
| <NoBuild>true</NoBuild> | |||
There was a problem hiding this comment.
This is unrelated to the fix, but allows for builds in VS to not fail. This same change is already in the master branch.
|
@jasonmalinowski Could you please take a look? |
dpoeschl
approved these changes
Mar 18, 2019
|
Note: This has been tested by the test team and myself. Only one bug was found, which is unrelated and has existed since 15.x. |
JoeRobich
commented
Mar 19, 2019
| var oldOptions = s_optionService.GetOptions(); | ||
| var newOptions = s_optionStore.GetOptions(); | ||
| s_optionService.SetOptions(newOptions); | ||
| OptionLogger.Log(oldOptions, newOptions); |
There was a problem hiding this comment.
As pointed out by David offline, we had been logging option changes on SaveSettings before the earlier PR moved logging into the OptionStore. This reverts the behavior back.
|
Integration test failure was already logged as #33652 |
jasonmalinowski
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34210 which was introduced by #33523
The earlier PR didn't account for the Naming option page having very specialized load and save settings. Other option pages were updated to store their changes immediately into the OptionStore but Naming options still relied on SaveSettings being called to directly update the OptionService. In a related way, Naming service overwrites its view model when LoadSettings is called and because of the earlier change LoadSettings was being called every time the page is activated.
Ask Mode template
Customer scenario
User tries to update naming styles for identifiers and changes do not save.
Bugs this fixes
#34210
Workarounds, if any
None
Risk
Low
Performance impact
Low
Is this a regression from a previous update?
Yes, regression was introduced by #33523
Root cause analysis
In Dev16, option saving was rewritten so that all option changes went to a centralized store and were saved to the option service in a single location. This rewrite missed the custom save behavior of the Naming styles option page.
How was the bug found?
Reported through developer feedback