Use toolset version from Arcade #36754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@RikkiGibson Could you take a look at this when you get a chance? |
RikkiGibson
reviewed
Jun 27, 2019
|
|
||
| # Dotnet diagnostic settings | ||
| [*.{cs,vb}] | ||
| dotnet_diagnostic.xUnit2018.severity = suppress # "do not compare an object's exact type to the abstract class" is a valid assert, but very noisy right now |
Member
There was a problem hiding this comment.
I assume this fixes a bunch of spurious warnings in the build?
Member
Author
There was a problem hiding this comment.
Yeah, this is reacting to a change where we renamed "suppress" in editorconfig to "none"
RikkiGibson
reviewed
Jun 27, 2019
| <MicrosoftInternalVisualStudioShellInterop140DesignTimeVersion>14.3.25407-alpha</MicrosoftInternalVisualStudioShellInterop140DesignTimeVersion> | ||
| <MicrosoftMetadataVisualizerVersion>1.0.0-beta1-63011-01</MicrosoftMetadataVisualizerVersion> | ||
| <MicrosoftMSXMLVersion>8.0.0.0-alpha</MicrosoftMSXMLVersion> | ||
| <MicrosoftNetCompilersToolsetVersion>3.2.0-beta4-19312-15</MicrosoftNetCompilersToolsetVersion> |
Member
There was a problem hiding this comment.
So the point is, let's use the same compiler to build Roslyn as we give to everyone else via Arcade?
RikkiGibson
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.