Skip to content

Skip nullable transform for simple value types #36784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
agocke merged 3 commits into from
Jun 26, 2019
Merged

Skip nullable transform for simple value types #36784

agocke merged 3 commits into from
Jun 26, 2019

Conversation

@cston
Copy link
Contributor

@cston cston commented Jun 26, 2019

No description provided.

@cston cston requested a review from a team as a code owner June 26, 2019 17:35
jcouv
jcouv approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv jcouv self-assigned this Jun 26, 2019
@jcouv jcouv added this to the 16.2.P4 milestone Jun 26, 2019
@cston cston mentioned this pull request Jun 26, 2019
Closed
@jcouv jcouv mentioned this pull request Jun 26, 2019
Merged
agocke
agocke approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agocke agocke closed this Jun 26, 2019
@agocke agocke reopened this Jun 26, 2019
@agocke
Copy link
Member

agocke commented Jun 26, 2019

Woops, sorry, closed wrong PR.

@agocke agocke changed the base branch from master to release/dev16.3-preview1 June 26, 2019 20:11
@agocke
Copy link
Member

agocke commented Jun 26, 2019

@cston I just rebased this to release/dev16.3-preview1

@RikkiGibson RikkiGibson modified the milestones: 16.2.P4, 16.3.P1 Jun 26, 2019
@agocke
Copy link
Member

agocke commented Jun 26, 2019

These tests were broken in the branch directly and were fixed in #36790

@agocke agocke merged commit f5a3caf into dotnet:release/dev16.3-preview1 Jun 26, 2019
agocke added a commit to agocke/roslyn that referenced this pull request Jun 28, 2019
@agocke
Revert "Skip nullable transform for simple value types (dotnet#36784)"
afcf392 
This reverts commit f5a3caf.
@jcouv jcouv mentioned this pull request Aug 22, 2019
Closed
@cston cston mentioned this pull request Aug 29, 2019
Closed
@cston cston deleted the valuetype branch March 15, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agocke agocke agocke approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels

Area-Compilers Feature - Nullable Reference Types Nullable Reference Types

Projects

None yet

Milestone

16.3.P1

Development

Successfully merging this pull request may close these issues.

4 participants

@cston @agocke @jcouv @RikkiGibson