Skip to content

Consistently name C#/VB editors #36898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2019
Merged

Consistently name C#/VB editors #36898

merged 1 commit into from
Jul 1, 2019

Conversation

@davkean
Copy link
Member

@davkean davkean commented Jul 1, 2019

This changes the names of the C# and VB editors so that they have a name that matches the other editors and usage elsewhere.

Old Name New Name
CSharp Editor C# Editor
CSharp Editor with Encoding C# Editor with Encoding
Microsoft Visual Basic Editor Visual Basic Editor
Microsoft Visual Basic Code Page Editor Visual Basic Editor with Encoding

This PR renames this usage:

image
image

@davkean
Consistently name C#/VB editors
041c34d 
This changes the names of the C# and VB editors so that they have a name that matches the other editors and usage elsewhere.
@davkean davkean requested a review from a team as a code owner July 1, 2019 03:21
@jinujoseph jinujoseph added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Jul 1, 2019
@jinujoseph jinujoseph added this to the 16.3 milestone Jul 1, 2019
@jinujoseph
Copy link
Contributor

jinujoseph commented Jul 1, 2019

cc @kendrahavens @mikadumont, @chborl FYI

@JoeRobich JoeRobich merged commit 54142de into dotnet:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

@JoeRobich JoeRobich JoeRobich approved these changes

+1 more reviewer

@sharwell sharwell sharwell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JoeRobich JoeRobich

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Milestone

16.3

Development

Successfully merging this pull request may close these issues.

5 participants

@davkean @jinujoseph @jasonmalinowski @JoeRobich @sharwell