move to new OperationProgress API. #37781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heejaechang
changed the title
…o newOperationProgressAPI
heejaechang
changed the title
heejaechang
changed the base branch from
master-vs-deps
to
release/dev16.3-vs-deps
Mohit-Chakraborty
approved these changes
Sep 5, 2019
sharwell
reviewed
Sep 6, 2019
Contributor
Author
|
@dotnet/roslyn-ide I need sign off from someone. platform team already signed off on their API usage. |
mavasani
approved these changes
Sep 6, 2019
Contributor
|
Should this go into dev16.3 branch or dev16.3-vs-deps? |
Contributor
Author
|
it is targetting 16.3 preview 4 |
jasonmalinowski
approved these changes
Sep 6, 2019
| <PropertyGroup> | ||
| <!-- Versions used by several individual references below --> | ||
| <RoslynDiagnosticsNugetPackageVersion>2.9.3</RoslynDiagnosticsNugetPackageVersion> | ||
| <RoslynDiagnosticsNugetPackageVersion>2.9.4</RoslynDiagnosticsNugetPackageVersion> |
Member
There was a problem hiding this comment.
@mavasani Was this the buggy version that had that big memory leak?
Contributor
There was a problem hiding this comment.
Memory leak has been there since 2.9.3, but we explicitly turned off all the DFA rules that could cause it in our solution ruleset. Not sure if 2.9.4 has more DFA rules on by default. I am planning to publish 2.9.5-beta1 today, which has the fix for the memory leak, and will submit a follow-up PR to move to that package before we merge this branch back to master.
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
existing OperationProgress API responded to any design-time build event and we would like to restrict it to the only one that caused by solution load scenario.
for that, platform team added new API and we are moving to that API.
other design-time build events caused by things like "Active Configuration change" or "git branch" switch scenario will be considered in next PLM (partial load mode) iteration.
in current iteration, it is only for solution load. and we are still under experiment on this PLM.