Fix deadlock due to VS Experiement service jumping to UI thread in certain cases. #38356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heejaechang
changed the title
...dio/Core/Def/Implementation/Remote/RemoteHostClientServiceFactory.RemoteHostClientService.cs
Outdated
Show resolved
Hide resolved
jasonmalinowski
approved these changes
Aug 28, 2019
...dio/Core/Def/Implementation/Remote/RemoteHostClientServiceFactory.RemoteHostClientService.cs
Outdated
Show resolved
Hide resolved
jasonmalinowski
requested changes
Aug 28, 2019
Member
jasonmalinowski
left a comment
jasonmalinowski
left a comment
There was a problem hiding this comment.
This is targeting the wrong branch.
Contributor
Author
|
@jasonmalinowski which branch should it target? |
heejaechang
changed the base branch from
master-vs-deps
to
release/dev16.3-vs-deps
… it can jump to other threads.
heejaechang
force-pushed
the
experimentService
branch
from
5c4642e to
8012e05
Compare
JoeRobich
added
Approved to merge
Needs Shiproom Approval
and removed
Approved to merge
labels
…make it generic fix without fixing underlying issue just make the issue to be hidden and spread more.
jasonmalinowski
approved these changes
Aug 29, 2019
vatsalyaagrawal
approved these changes
Aug 29, 2019
Member
|
The failing unit tests are completion test which are known flaky in the vs-deps branches. Merging this forward. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure to acquire IExperiementationService outside of a lock so that we don't get into deadlock in certain cases.