Merge master to features/local-function-attributes #39012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AddImportService now uses the context for better choice of whee to add imports. AddImportService first checks which namespaces need to be added, then adds them. This will be necessary when we want to make the addition safe, to avoid doing more work than we need to.
…irHalberstadt/roslyn into feature/add-import-annotation
…icAddImportsService.MakeSafeToAddNamespaces
fix change in warning in tests, and slight cleanup of CsharpImportAdder.CanHaveDocComments
…different case in VB
ImportAdder ImportAdderService CSharpImportAdder
Remove Undeclared variable left in AbstractAddImportsService accidentally
My previous PR #38666 to improve performance for the analyzer introduced a functional regression in SymbolUsageAnalysis, which is fixed by this change.
Fix regression in RemoveUnusedParametersAndValues analyzer
Make AddImports internal.
…otation Feature/add import annotation
Delete some dead code from the rename test harness
…001.4 (#38996) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19501.4
Check language version on relaxed ordering of parameter modifiers
|
Hello @dotnet-bot! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 12 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into features/local-function-attributes.
git fetch --all git checkout merges/master-to-features/local-function-attributes git reset --hard upstream/features/local-function-attributes git merge upstream/master # Fix merge conflicts git commit git push upstream merges/master-to-features/local-function-attributes --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.