-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Add annotations for symbol-related types and interfaces #39054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sharwell
wants to merge
24
commits into
dotnet:main
Choose a base branch
from
sharwell:symbol-annotations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
commented
Oct 4, 2019
| /// </summary> | ||
| string MetadataName { get; } | ||
|
|
||
| #nullable disable |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Skipping the Containing* properties made this pull request viable. I will not be addressing these properties in this pull request.
30377b3 to
6252bd2
Compare
bf34745 to
f7cef51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area-Compilers
Concept-Null Annotations
The issue involves annotating an API for nullable reference types
PR For Personal Review Only
The PR doesn’t require anyone other than the developer to review it.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 Builds on #39053. After that one is merged, many files will drop out of this pull request.
Each commit was verified to compile successfully without new warnings, so reviewers do have the option of going commit-by-commit.