Skip to content

Conversation

@nnpcYvIVl
Copy link
Contributor

No description provided.

@nnpcYvIVl nnpcYvIVl requested review from a team as code owners October 4, 2019 02:28
// find all explicit and implicit interface implementations.
// We need to start from each base class for cases like N() Implements I.M()
// where N() can be hidden or overwritted in a nested class later on.
// where N() can be hidden or overwritten in a nested class later on.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect they meant to say "overridden"...

@jasonmalinowski
Copy link
Member

@dotnet/roslyn-compiler Would need a review from you as well.

Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nnpcYvIVl, we appreciate you taking the time to submit spelling fixes for Roslyn. However, could we ask you to please batch your fixes in larger groups? If it's just spelling fixes, please limit to just one open PR at a time, and please try to send several days worth of fixes at once, rather than just a few changes per PR. Reviewing every PR you credate is taking up developer time, as well as running a lot of CI infrastructure. A single PR with larger group of spelling fix commits would be easier to review and use up less build resources. Thanks.

@333fred 333fred merged commit 1dcad2d into dotnet:master Oct 4, 2019
@nnpcYvIVl
Copy link
Contributor Author

@333fred Roger, will do! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants