Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dedicated tuple type symbol #39370

Merged
merged 22 commits into from
Dec 17, 2019
Merged

Remove dedicated tuple type symbol #39370

merged 22 commits into from
Dec 17, 2019

Commits on Dec 5, 2019

  1. Refactor tuple implementation

    @jcouv
    jcouv committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    468d190 View commit details
    Browse the repository at this point in the history

  2. Tweaks

    @jcouv
    jcouv committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    af9f7af View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2019

  1. Address PR feedback

    @jcouv
    jcouv committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    17e6fb2 View commit details
    Browse the repository at this point in the history

  2. Pass tuple data in constructors

    @jcouv
    jcouv committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    976d36d View commit details
    Browse the repository at this point in the history

  3. Address more feedback

    @jcouv
    jcouv committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    84a90f7 View commit details
    Browse the repository at this point in the history

  4. Tweak comparison

    @jcouv
    jcouv committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    9a7a517 View commit details
    Browse the repository at this point in the history

  5. Restore constructWithTypeParameters flag to avoid overflow

    @jcouv
    jcouv committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    81f37b7 View commit details
    Browse the repository at this point in the history

  6. Assert that tuple parameter matches TupleUnderlyingType somewhat

    @jcouv
    jcouv committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    2f49a69 View commit details
    Browse the repository at this point in the history

  7. Rename to TupleData. Address some IDE feedback

    @jcouv
    jcouv committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    7610742 View commit details
    Browse the repository at this point in the history

  8. Remaining TODO2's

    @jcouv
    jcouv committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    827d95a View commit details
    Browse the repository at this point in the history

  9. Fix last IDE test!

    @jcouv
    jcouv committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    c88b2c3 View commit details
    Browse the repository at this point in the history

  10. Factor array comparison

    @jcouv
    jcouv committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    2eee323 View commit details
    Browse the repository at this point in the history

  11. Tweak WithTupleData and EqualsIgnoringTupleUnderlyingType

    @jcouv
    jcouv committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    1103f27 View commit details
    Browse the repository at this point in the history

  12. Expand a test

    @jcouv
    jcouv committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    0d79f35 View commit details
    Browse the repository at this point in the history

  13. Remove duplicate line

    @jcouv
    jcouv committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    cbe211c View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2019

  1. Remove an EE test for badly formed ValueTuple type

    @jcouv
    jcouv committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    fcf55a5 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'dotnet/master' into tuple-symbols

    @jcouv
    jcouv committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    e8059fb View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2019

  1. PR feedback from Neal

    @jcouv
    jcouv committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    d4342ba View commit details
    Browse the repository at this point in the history

  2. Restore an IDE test without ValueTuple

    @jcouv
    jcouv committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    8b9c722 View commit details
    Browse the repository at this point in the history

  3. Rename constants

    @jcouv
    jcouv committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    b25d1ec View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2019

  1. Merge remote-tracking branch 'dotnet/master' into tuple-symbols

    @jcouv
    jcouv committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    e686f4e View commit details
    Browse the repository at this point in the history

  2. Restore formatting

    @jcouv
    jcouv committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    c935653 View commit details
    Browse the repository at this point in the history