Cleanup fix all code. #41512
Merged
Cleanup fix all code. #41512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Tagging @mavasani |
jinujoseph
added
Area-IDE
Community
mavasani
approved these changes
Feb 10, 2020
Contributor
|
Thanks @CyrusNajmabadi. @dotnet/roslyn-ide Anyone else wants to take a look? This is just cleaning up code to remove some internal API dependencies so it can eventually be pulled into the shared layer to be consumed by CodeStyle layer. |
sharwell
reviewed
Feb 10, 2020
...res/Core/Portable/CodeFixes/Suppression/AbstractSuppressionCodeFixProvider.FixAllProvider.cs
Show resolved
Hide resolved
src/Workspaces/Core/Portable/CodeFixes/FixAllOccurrences/FixAllContext.DiagnosticProvider.cs
Show resolved
Hide resolved
src/Workspaces/Core/Portable/CodeFixes/FixAllOccurrences/FixAllContext.DiagnosticProvider.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/Core/Portable/CodeFixes/FixAllOccurrences/BatchFixAllProvider.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
Feb 10, 2020
...res/Core/Portable/CodeFixes/Suppression/AbstractSuppressionCodeFixProvider.FixAllProvider.cs
Outdated
Show resolved
Hide resolved
sharwell
approved these changes
Feb 10, 2020
mavasani
approved these changes
Feb 10, 2020
Contributor
mavasani
left a comment
mavasani
left a comment
There was a problem hiding this comment.
Awesome, thanks @CyrusNajmabadi and @sharwell
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #41510 to make that PR easier to review.