Faster suppressions #42962
Merged
Faster suppressions #42962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
reviewed
Apr 2, 2020
Contributor
Author
|
@dotnet/roslyn-compiler for a second review. This is a dogfood blocker to fix for 16.6 Preview 3. |
333fred
approved these changes
Apr 3, 2020
Contributor
Author
|
@dotnet/roslyn-compiler for a second review. |
AlekseyTs
reviewed
Apr 3, 2020
AlekseyTs
reviewed
Apr 3, 2020
Contributor
|
Done with review pass (iteration 4) #Closed |
AlekseyTs
reviewed
Apr 3, 2020
AlekseyTs
dismissed
their stale review
It looks like there is a chance of a NullReferenceException in GetHashCode.
Contributor
Author
|
@AlekseyTs responded to feedback |
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes performance issues when using diagnostic suppressors.