Misc. changes related to Simple Programs #43213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to dotnet#41704. - Add tests for missing types that the feature depends upon. - Adjust binding to produce a ```BoundNonConstructorMethodBody``` as the root of the bound body to be consistent with other flavors of ```BindMethodBody```. - Report an error when a "MainType" is speciafied for a Simple Program. - Improve parsing error recovery around local functions.
RikkiGibson
approved these changes
Apr 9, 2020
Contributor
Author
|
@cston, @dotnet/roslyn-compiler Please review, need a second sign-off. |
Contributor
Author
|
@cston, @dotnet/roslyn-compiler Please review, need a second sign-off for a relatively small change. |
1 similar comment
Contributor
Author
|
@cston, @dotnet/roslyn-compiler Please review, need a second sign-off for a relatively small change. |
cston
approved these changes
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #41704.
BoundNonConstructorMethodBodyas the root of the bound body to be consistent with other flavors ofBindMethodBody.