Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specially handle tuple methods in CodeGenerator.EmitMethodInfoExpression for VB. #43553

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Specially handle tuple methods in CodeGenerator.EmitMethodInfoExpression for VB. #43553

merged 1 commit into from
Apr 23, 2020

Conversation

AlekseyTs
Copy link
Contributor

Fixes #27322.

@AlekseyTs AlekseyTs requested a review from a team as a code owner April 22, 2020 01:39
@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler Please review

gafter
gafter approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@gafter gafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekseyTs AlekseyTs merged commit 831c257 into dotnet:master Apr 23, 2020
@ghost ghost added this to the Next milestone Apr 23, 2020
333fred added a commit to 333fred/roslyn that referenced this pull request Apr 23, 2020
@333fred
Merge remote-tracking branch 'upstream/master' into merge-master
86c102a 
* upstream/master: (1099 commits)
  Specially handle tuple methods in CodeGenerator.EmitMethodInfoExpression for VB. (dotnet#43553)
  Remove unnecessary usings
  AssetStorage cleanup (dotnet#43511)
  Remove unused code (dotnet#43556)
  Revert anonymous type DebuggerDisplay change (dotnet#43575)
  Replace GeneratePkgDef with impl that does not load assemblies (dotnet#43302)
  Fix
  Update src/Analyzers/Core/CodeFixes/MakeFieldReadonly/AbstractMakeFieldReadonlyCodeFixProvider.cs
  PR feedback
  use capacity when creating builders.
  Push options down.
  Rename methods
  Fix GetSymbolInfo on ValueTuple declaration (dotnet#43467)
  Add support for cref-type-parameters.
  Support OOP with dynamic types.
  Support error locals in symbolkey
  Update tests to run OOP
  Update docs/Language Feature Status.md
  Update for partial methods
  Fix typos (dotnet#43494)
  ...
@sharwell sharwell modified the milestones: Next, temp, 16.7.P1 Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gafter gafter gafter approved these changes

@cston cston cston approved these changes

Assignees
No one assigned
Labels
Area-Compilers Language-VB New Language Feature - Tuples Tuples
Projects
None yet
Milestone
16.7.P1
Development

Successfully merging this pull request may close these issues.

Generated code for Expression-tree instantiation crashes when it refers to ValueTuple<A,B>.Equals
4 participants
@AlekseyTs @gafter @cston @sharwell