Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert anonymous type DebuggerDisplay change #43575

Merged
merged 4 commits into from
Apr 23, 2020
Merged

Conversation

tmat
Copy link
Member

@tmat tmat commented Apr 22, 2020

Turns out the leading backslash is needed in order to escape { that would otherwise be interpreted as a start of embedded expression by the debugger.

Original PR: #43211

@tmat tmat requested a review from a team as a code owner April 22, 2020 21:38
@tmat
Copy link
Member Author

tmat commented Apr 22, 2020

@cston @jcouv PTAL. We figured out why the backslash was there. Without it the EE is broken. We need to fix interactive object formatter to interpret it correctly.

@tmat
Copy link
Member Author

tmat commented Apr 22, 2020

@mizuniga

Copy link
Member

@gafter gafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tmat tmat merged commit 64e10c3 into dotnet:master Apr 23, 2020
@ghost ghost added this to the Next milestone Apr 23, 2020
@tmat tmat deleted the RevertAnonTypeFix branch April 23, 2020 01:24
333fred added a commit to 333fred/roslyn that referenced this pull request Apr 23, 2020
* upstream/master: (1099 commits)
  Specially handle tuple methods in CodeGenerator.EmitMethodInfoExpression for VB. (dotnet#43553)
  Remove unnecessary usings
  AssetStorage cleanup (dotnet#43511)
  Remove unused code (dotnet#43556)
  Revert anonymous type DebuggerDisplay change (dotnet#43575)
  Replace GeneratePkgDef with impl that does not load assemblies (dotnet#43302)
  Fix
  Update src/Analyzers/Core/CodeFixes/MakeFieldReadonly/AbstractMakeFieldReadonlyCodeFixProvider.cs
  PR feedback
  use capacity when creating builders.
  Push options down.
  Rename methods
  Fix GetSymbolInfo on ValueTuple declaration (dotnet#43467)
  Add support for cref-type-parameters.
  Support OOP with dynamic types.
  Support error locals in symbolkey
  Update tests to run OOP
  Update docs/Language Feature Status.md
  Update for partial methods
  Fix typos (dotnet#43494)
  ...
@sharwell sharwell modified the milestones: Next, temp, 16.7.P1 Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants