Remove blank lines between close braces that are on different lines. #43822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlekseyTs
previously requested changes
Apr 30, 2020
Contributor
AlekseyTs
left a comment
AlekseyTs
left a comment
There was a problem hiding this comment.
I do not think this is useful or should be enforced.
Contributor
|
@AlekseyTs The new styles will be discussed with the cross-team style review group before getting enabled or merged. |
cston
approved these changes
Apr 30, 2020
jasonmalinowski
approved these changes
Apr 30, 2020
Member
Author
|
For context, there are 121017 cases where we follow the expected style, and 66 cases where we don't. So this is the defacto style for the entire roslyn project to the tune of 99.945%. As far as i can tell, this is our style. And this analyzer just catches the errant mistakes that occasionally happen and slip through the cracks. This helps makes PRs easier to review because this is no longer an issue that people have to be on guard about when reviewing :) |
This change excludes src/Compilers from the analysis.
sharwell
force-pushed
the
removeBlankLineBetweenBraces
branch
from
59dbb2b to
d57fa55
Compare
sharwell
dismissed
AlekseyTs’s stale review
All changes under src/Compilers have been removed/excluded
sharwell
approved these changes
May 21, 2020
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the result of running the latest analyzer in roslyn-analyzers against Roslyn.sln. This will be needed to move to the latest version for the team.