Revert "Make boolean value factory resilient in the face of errors." #44575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gafter
approved these changes
May 26, 2020
Member
gafter
left a comment
gafter
left a comment
There was a problem hiding this comment.
How will we ensure this fix remains in master?
Member
Author
|
IIRC, we do it by merging this and committing a "revert to the revert" when it reaches master. |
RikkiGibson
added a commit
to RikkiGibson/roslyn
that referenced
this pull request
May 28, 2020
…rrors. (dotnet#44441)" (dotnet#44575)" This reverts commit 4afa268.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #44441
We are not taking this fix in preview2. We will take the fix in preview3.
This revert will bring the branch contents into parity with what we have actually inserted into VS 16.7-preview2.