Skip to content

Address final prototype comments. #44715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2020
Merged

Address final prototype comments. #44715

merged 2 commits into from
May 30, 2020

Conversation

@333fred
Copy link
Member

@333fred 333fred commented May 30, 2020

No description provided.

@333fred 333fred requested review from a team as code owners May 30, 2020 02:55
@333fred 333fred requested a review from AlekseyTs May 30, 2020 02:55
@333fred
Copy link
Member Author

333fred commented May 30, 2020

@dotnet/roslyn-compiler @AlekseyTs for review.

AlekseyTs
AlekseyTs approved these changes May 30, 2020
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (iteration 1)

@333fred
Copy link
Member Author

333fred commented May 30, 2020

@dotnet/roslyn-compiler for a second review.

@333fred 333fred merged commit 0ca488c into dotnet:features/function-pointers May 30, 2020
@333fred 333fred deleted the prototype-removal branch May 30, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

+1 more reviewer

@cston cston cston approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Compilers Feature - Function Pointers Adding Function Pointers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@333fred @AlekseyTs @cston