diff --git a/src/Compilers/Core/Portable/CommandLine/CommandLineParser.cs b/src/Compilers/Core/Portable/CommandLine/CommandLineParser.cs index d7659ef138cd8..2a2393f4a2575 100644 --- a/src/Compilers/Core/Portable/CommandLine/CommandLineParser.cs +++ b/src/Compilers/Core/Portable/CommandLine/CommandLineParser.cs @@ -350,12 +350,8 @@ internal void ParseOutputFile( out string? outputFileName, out string? outputDirectory) { - outputFileName = null; - outputDirectory = null; - string? invalidPath = null; - string unquoted = RemoveQuotesAndSlashes(value); - ParseAndNormalizeFile(unquoted, baseDirectory, out outputFileName, out outputDirectory, out invalidPath); + ParseAndNormalizeFile(unquoted, baseDirectory, out outputFileName, out outputDirectory, out string? invalidPath); if (outputFileName == null || !MetadataHelpers.IsValidAssemblyOrModuleName(outputFileName)) { @@ -370,13 +366,10 @@ internal void ParseOutputFile( IList errors, string? baseDirectory) { - string? outputFileName = null; - string? outputDirectory = null; string? pdbPath = null; - string? invalidPath = null; string unquoted = RemoveQuotesAndSlashes(value); - ParseAndNormalizeFile(unquoted, baseDirectory, out outputFileName, out outputDirectory, out invalidPath); + ParseAndNormalizeFile(unquoted, baseDirectory, out string? outputFileName, out string? outputDirectory, out string? invalidPath); if (outputFileName == null || PathUtilities.ChangeExtension(outputFileName, extension: null).Length == 0) { @@ -398,12 +391,9 @@ internal void ParseOutputFile( string? baseDirectory, bool generateDiagnostic = true) { - string? outputFileName = null; - string? outputDirectory = null; string? genericPath = null; - string? invalidPath = null; - ParseAndNormalizeFile(unquoted, baseDirectory, out outputFileName, out outputDirectory, out invalidPath); + ParseAndNormalizeFile(unquoted, baseDirectory, out string? outputFileName, out string? outputDirectory, out string? invalidPath); if (string.IsNullOrWhiteSpace(outputFileName)) { if (generateDiagnostic) @@ -559,9 +549,7 @@ internal static bool TryParseClientArgs( var newArgs = new List(); foreach (var arg in args) { - bool hasValue; - string? value; - if (isClientArgsOption(arg, "keepalive", out hasValue, out value)) + if (isClientArgsOption(arg, "keepalive", out bool hasValue, out string? value)) { if (string.IsNullOrEmpty(value)) { @@ -569,8 +557,7 @@ internal static bool TryParseClientArgs( return false; } - int intValue; - if (int.TryParse(value, out intValue)) + if (int.TryParse(value, out int intValue)) { if (intValue < -1) { @@ -618,7 +605,7 @@ internal static bool TryParseClientArgs( return true; } - bool isClientArgsOption(string arg, string optionName, out bool hasValue, out string? optionValue) + static bool isClientArgsOption(string arg, string optionName, out bool hasValue, out string? optionValue) { hasValue = false; optionValue = null; @@ -660,13 +647,11 @@ internal IEnumerable ParseResponseFile(string fullPath, IList ParseRecurseArgument(string arg, str internal static Encoding? TryParseEncodingName(string arg) { - long codepage; if (!string.IsNullOrWhiteSpace(arg) - && long.TryParse(arg, NumberStyles.None, CultureInfo.InvariantCulture, out codepage) + && long.TryParse(arg, NumberStyles.None, CultureInfo.InvariantCulture, out long codepage) && (codepage > 0)) { try