From dfaca6bf25077d467527dc5277eb26fecb987aa5 Mon Sep 17 00:00:00 2001 From: Rikki Gibson Date: Thu, 3 Feb 2022 10:02:56 -0800 Subject: [PATCH] Revert "Remove dependency on EditorFeatures from Remote.ServiceHub project - take 2 (#59147)" This reverts commit d5763e928b011d64eb26fe9a8a8a7e199153fecd. --- eng/targets/Services.props | 2 +- .../CSharpDecompiledSourceService.cs | 2 +- .../FindUsages/CSharpFindUsagesLSPService.cs | 5 +- .../FindUsages/CSharpFindUsagesService.cs | 2 +- .../FindBaseSymbolsCommandHandler.cs | 2 +- .../FindDerivedSymbolsCommandHandler.cs | 2 +- .../FindExtensionMethodsCommandHandler.cs | 2 +- .../FindImplementingMembersCommandHandler.cs | 1 + .../FindMemberOverloadsCommandHandler.cs | 2 +- ...FindReferencesOfOverloadsCommandHandler.cs | 2 +- .../Core.Wpf/Peek/PeekableItemFactory.cs | 3 +- .../Core/EditorFeaturesResources.resx | 9 ++ .../VSTypeScriptFindUsagesService.cs | 1 + .../FindReferencesCommandHandler.cs | 2 +- ...UsagesService.DefinitionTrackingContext.cs | 2 +- ...stractFindUsagesService.ProgressAdapter.cs | 2 +- .../FindUsages/AbstractFindUsagesService.cs | 4 +- ...ctFindUsagesService_FindImplementations.cs | 8 +- ...bstractFindUsagesService_FindReferences.cs | 6 +- .../Core}/FindUsages/FindUsagesContext.cs | 0 .../IDefinitionsAndReferencesFactory.cs | 3 +- .../Core}/FindUsages/IFindUsagesLSPService.cs | 2 +- .../Core}/FindUsages/IFindUsagesService.cs | 2 +- .../FindUsages/SimpleFindUsagesContext.cs | 2 +- .../Core/GoToBase/AbstractGoToBaseService.cs | 3 +- .../AbstractGoToDefinitionService.cs | 1 + .../GoToDefinitionCommandHandler.cs | 2 +- .../GoToDefinition/GoToDefinitionHelpers.cs | 1 + .../GoToImplementationCommandHandler.cs | 1 + ...lassificationTaggerProvider.TagComputer.cs | 2 +- .../DefinitionContextTracker.cs | 2 +- .../References/FindAllReferencesHandler.cs | 2 +- .../References/FindImplementationsHandler.cs | 2 +- .../NavigationBar/NavigationBarController.cs | 4 +- .../InheritanceMarginServiceHelpers.cs | 1 + ...crosoft.CodeAnalysis.EditorFeatures.csproj | 2 + .../Tagging/EventSources/TaggerConstants.cs | 16 ++- .../AbstractStackTraceSymbolResolver.cs | 5 +- .../StackFrameLocalMethodResolver.cs | 2 +- .../StackFrameMethodSymbolResolver.cs | 2 +- .../StackTraceExplorerService.cs | 3 +- .../StackTraceExplorerUtilities.cs | 4 +- .../IAddReferenceDatabaseWrapper.cs | 0 .../SymbolSearch}/IDatabaseFactoryService.cs | 0 .../Core/SymbolSearch}/IDelayService.cs | 0 .../Core/SymbolSearch}/IIOService.cs | 0 .../Core/SymbolSearch}/IPatchService.cs | 0 .../SymbolSearch}/IRemoteControlService.cs | 0 .../Core/SymbolSearch/Patching/Delta.cs} | 6 +- ...archUpdateEngine.DatabaseFactoryService.cs | 0 .../SymbolSearchUpdateEngine.DelayService.cs | 0 .../SymbolSearchUpdateEngine.IOService.cs | 0 .../SymbolSearchUpdateEngine.PatchService.cs | 2 +- ...SearchUpdateEngine.RemoteControlService.cs | 0 .../SymbolSearchUpdateEngine.Update.cs | 0 .../SymbolSearch}/SymbolSearchUpdateEngine.cs | 0 .../SymbolSearchUpdateEngineFactory.cs | 114 ++++++++++++++++++ .../CompilationAvailableTaggerEventSource.cs | 11 +- .../Core/xlf/EditorFeaturesResources.cs.xlf | 25 +++- .../Core/xlf/EditorFeaturesResources.de.xlf | 25 +++- .../Core/xlf/EditorFeaturesResources.es.xlf | 25 +++- .../Core/xlf/EditorFeaturesResources.fr.xlf | 25 +++- .../Core/xlf/EditorFeaturesResources.it.xlf | 25 +++- .../Core/xlf/EditorFeaturesResources.ja.xlf | 25 +++- .../Core/xlf/EditorFeaturesResources.ko.xlf | 25 +++- .../Core/xlf/EditorFeaturesResources.pl.xlf | 25 +++- .../xlf/EditorFeaturesResources.pt-BR.xlf | 25 +++- .../Core/xlf/EditorFeaturesResources.ru.xlf | 25 +++- .../Core/xlf/EditorFeaturesResources.tr.xlf | 25 +++- .../xlf/EditorFeaturesResources.zh-Hans.xlf | 25 +++- .../xlf/EditorFeaturesResources.zh-Hant.xlf | 25 +++- .../StackTraceExplorerTests.cs | 2 +- .../FindReferences/FindReferencesTests.vb | 1 + .../Test2/GoToBase/GoToBaseTestsBase.vb | 2 +- .../Test2/GoToHelpers/GoToHelpers.vb | 2 +- .../GoToImplementationTests.vb | 2 +- .../MockNavigableItemsPresenter.vb | 3 +- .../VisualBasicFindUsagesLSPService.vb | 3 +- .../VisualBasicFindUsagesService.vb | 2 +- .../Core/Portable/Common/DelayTimeSpan.cs | 17 --- .../Core/Portable/FeaturesResources.resx | 12 -- .../Core/Portable/FindUsages/ExternalScope.cs | 2 + .../Portable/FindUsages/FindUsagesHelpers.cs | 2 +- .../AbstractFindDefinitionService.cs | 2 +- .../Microsoft.CodeAnalysis.Features.csproj | 8 +- .../StackTraceExplorerOptions.cs | 21 ++++ .../SymbolSearchUpdateEngineFactory.cs | 26 ---- .../SymbolSearchUpdateNoOpEngine.cs | 28 ----- .../SymbolSearchUpdateEngineFactory.cs | 49 -------- .../Windows/SymbolSearchUpdateEngineProxy.cs | 61 ---------- .../Tagging/CompilationAvailableHelpers.cs | 16 --- .../Portable/xlf/FeaturesResources.cs.xlf | 20 --- .../Portable/xlf/FeaturesResources.de.xlf | 20 --- .../Portable/xlf/FeaturesResources.es.xlf | 20 --- .../Portable/xlf/FeaturesResources.fr.xlf | 20 --- .../Portable/xlf/FeaturesResources.it.xlf | 20 --- .../Portable/xlf/FeaturesResources.ja.xlf | 20 --- .../Portable/xlf/FeaturesResources.ko.xlf | 20 --- .../Portable/xlf/FeaturesResources.pl.xlf | 20 --- .../Portable/xlf/FeaturesResources.pt-BR.xlf | 20 --- .../Portable/xlf/FeaturesResources.ru.xlf | 20 --- .../Portable/xlf/FeaturesResources.tr.xlf | 20 --- .../xlf/FeaturesResources.zh-Hans.xlf | 20 --- .../xlf/FeaturesResources.zh-Hant.xlf | 20 --- .../Debugger/DebuggerFindReferencesService.cs | 2 +- .../FindUsages/FSharpFindUsagesService.cs | 1 + .../Options/AdvancedOptionPageControl.xaml.cs | 2 +- ...alStudioDefinitionsAndReferencesFactory.cs | 1 + .../AbstractObjectBrowserLibraryManager.cs | 4 +- .../VisualStudioSymbolNavigationService.cs | 1 + .../PdbSourceDocumentOutputWindowLogger.cs | 3 +- .../StackTraceExplorerCommandHandler.cs | 9 +- .../StackTraceExplorerOptions.cs | 35 ------ .../Venus/DocumentService_IntegrationTests.vb | 2 +- .../Fakes/StubStreamingFindUsagesPresenter.cs | 1 + .../Remote/InProcRemostHostClient.cs | 2 +- ...soft.CodeAnalysis.Remote.ServiceHub.csproj | 1 + .../FindUsages/RemoteFindUsagesService.cs | 1 + ...teSemanticClassificationService.Caching.cs | 3 +- .../RemoteStackTraceExplorerService.cs | 4 +- ...RemoteTaggerCompilationAvailableService.cs | 4 +- 121 files changed, 528 insertions(+), 650 deletions(-) rename src/{Features/Core/Portable => EditorFeatures/Core}/FindUsages/AbstractFindUsagesService.DefinitionTrackingContext.cs (98%) rename src/{Features/Core/Portable => EditorFeatures/Core}/FindUsages/AbstractFindUsagesService.ProgressAdapter.cs (99%) rename src/{Features/Core/Portable => EditorFeatures/Core}/FindUsages/AbstractFindUsagesService.cs (75%) rename src/{Features/Core/Portable => EditorFeatures/Core}/FindUsages/AbstractFindUsagesService_FindImplementations.cs (96%) rename src/{Features/Core/Portable => EditorFeatures/Core}/FindUsages/AbstractFindUsagesService_FindReferences.cs (98%) rename src/{Features/Core/Portable => EditorFeatures/Core}/FindUsages/FindUsagesContext.cs (100%) rename src/{Features/Core/Portable => EditorFeatures/Core}/FindUsages/IDefinitionsAndReferencesFactory.cs (99%) rename src/{Features/Core/Portable => EditorFeatures/Core}/FindUsages/IFindUsagesLSPService.cs (95%) rename src/{Features/Core/Portable => EditorFeatures/Core}/FindUsages/IFindUsagesService.cs (95%) rename src/{Features/Core/Portable => EditorFeatures/Core}/FindUsages/SimpleFindUsagesContext.cs (97%) rename src/{Features/Core/Portable => EditorFeatures/Core}/InheritanceMargin/InheritanceMarginServiceHelpers.cs (99%) rename src/{Features/Core/Portable => EditorFeatures/Core}/StackTraceExplorer/AbstractStackTraceSymbolResolver.cs (95%) rename src/{Features/Core/Portable => EditorFeatures/Core}/StackTraceExplorer/StackFrameLocalMethodResolver.cs (96%) rename src/{Features/Core/Portable => EditorFeatures/Core}/StackTraceExplorer/StackFrameMethodSymbolResolver.cs (95%) rename src/{Features/Core/Portable => EditorFeatures/Core}/StackTraceExplorer/StackTraceExplorerService.cs (97%) rename src/{Features/Core/Portable => EditorFeatures/Core}/StackTraceExplorer/StackTraceExplorerUtilities.cs (97%) rename src/{Features/Core/Portable/SymbolSearch/Windows => EditorFeatures/Core/SymbolSearch}/IAddReferenceDatabaseWrapper.cs (100%) rename src/{Features/Core/Portable/SymbolSearch/Windows => EditorFeatures/Core/SymbolSearch}/IDatabaseFactoryService.cs (100%) rename src/{Features/Core/Portable/SymbolSearch/Windows => EditorFeatures/Core/SymbolSearch}/IDelayService.cs (100%) rename src/{Features/Core/Portable/SymbolSearch/Windows => EditorFeatures/Core/SymbolSearch}/IIOService.cs (100%) rename src/{Features/Core/Portable/SymbolSearch/Windows => EditorFeatures/Core/SymbolSearch}/IPatchService.cs (100%) rename src/{Features/Core/Portable/SymbolSearch/Windows => EditorFeatures/Core/SymbolSearch}/IRemoteControlService.cs (100%) rename src/{Features/Core/Portable/SymbolSearch/Windows/NativePatching.cs => EditorFeatures/Core/SymbolSearch/Patching/Delta.cs} (94%) rename src/{Features/Core/Portable/SymbolSearch/Windows => EditorFeatures/Core/SymbolSearch}/SymbolSearchUpdateEngine.DatabaseFactoryService.cs (100%) rename src/{Features/Core/Portable/SymbolSearch/Windows => EditorFeatures/Core/SymbolSearch}/SymbolSearchUpdateEngine.DelayService.cs (100%) rename src/{Features/Core/Portable/SymbolSearch/Windows => EditorFeatures/Core/SymbolSearch}/SymbolSearchUpdateEngine.IOService.cs (100%) rename src/{Features/Core/Portable/SymbolSearch/Windows => EditorFeatures/Core/SymbolSearch}/SymbolSearchUpdateEngine.PatchService.cs (88%) rename src/{Features/Core/Portable/SymbolSearch/Windows => EditorFeatures/Core/SymbolSearch}/SymbolSearchUpdateEngine.RemoteControlService.cs (100%) rename src/{Features/Core/Portable/SymbolSearch/Windows => EditorFeatures/Core/SymbolSearch}/SymbolSearchUpdateEngine.Update.cs (100%) rename src/{Features/Core/Portable/SymbolSearch/Windows => EditorFeatures/Core/SymbolSearch}/SymbolSearchUpdateEngine.cs (100%) create mode 100644 src/EditorFeatures/Core/SymbolSearch/SymbolSearchUpdateEngineFactory.cs delete mode 100644 src/Features/Core/Portable/Common/DelayTimeSpan.cs create mode 100644 src/Features/Core/Portable/StackTraceExplorer/StackTraceExplorerOptions.cs delete mode 100644 src/Features/Core/Portable/SymbolSearch/SourceBuild/SymbolSearchUpdateEngineFactory.cs delete mode 100644 src/Features/Core/Portable/SymbolSearch/SymbolSearchUpdateNoOpEngine.cs delete mode 100644 src/Features/Core/Portable/SymbolSearch/Windows/SymbolSearchUpdateEngineFactory.cs delete mode 100644 src/Features/Core/Portable/SymbolSearch/Windows/SymbolSearchUpdateEngineProxy.cs delete mode 100644 src/Features/Core/Portable/Tagging/CompilationAvailableHelpers.cs delete mode 100644 src/VisualStudio/Core/Def/StackTraceExplorer/StackTraceExplorerOptions.cs diff --git a/eng/targets/Services.props b/eng/targets/Services.props index 316192a92ea15..c4421f0d7a042 100644 --- a/eng/targets/Services.props +++ b/eng/targets/Services.props @@ -38,7 +38,7 @@ - +