Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report telemetry event with LSP server capabilities #66334

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Report telemetry event with LSP server capabilities #66334

merged 1 commit into from
Jan 12, 2023

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Jan 9, 2023

On initialize, report the capabilities the server was started with. This is useful for session debugging so we know what LSP features are on/off.

image

@dibarbet dibarbet added Area-IDE LSP issues related to the roslyn language server protocol implementation labels Jan 9, 2023
@dibarbet dibarbet requested a review from a team as a code owner January 9, 2023 21:43
@dibarbet dibarbet merged commit 4fb0fcd into dotnet:main Jan 12, 2023
@dibarbet dibarbet deleted the report_lsp_initialization branch January 12, 2023 00:27
@ghost ghost added this to the Next milestone Jan 12, 2023
@allisonchou allisonchou mentioned this pull request Jan 18, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.6 P1 Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genlu genlu genlu approved these changes

@sharwell sharwell Awaiting requested review from sharwell

@CyrusNajmabadi CyrusNajmabadi Awaiting requested review from CyrusNajmabadi

Assignees
No one assigned
Labels
Area-IDE LSP issues related to the roslyn language server protocol implementation
Projects
None yet
Milestone
17.6 P1
Development

Successfully merging this pull request may close these issues.
3 participants
@dibarbet @genlu @Cosifne