Introduce placeholders for deprecated GeneratedNameKinds #6712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Contributor
There was a problem hiding this comment.
Minor point: Consider [Obsolete] instead rather than long, repeated error message.
Member
There was a problem hiding this comment.
+1. Just remove the message. Once somebody hits this they'll read the comment
Contributor
|
LGTM |
Member
|
👍 |
...to ensure we don't reuse values that could have been emitted by dev12. Fixes internal bug 163613.
amcasey
force-pushed
the
DeprecatedGeneratedNameKinds
branch
from
657578b to
cc5685d
Compare
amcasey
added a commit
that referenced
this pull request
Nov 11, 2015
Introduce placeholders for deprecated GeneratedNameKinds
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to ensure we don't reuse values that could have been emitted by dev12.
Fixes internal bug 163613.