Add support for 'primary header spans' in sticky-scroll. #68450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
genlu
reviewed
Jun 6, 2023
eng/Versions.props
Outdated
| @@ -110,8 +110,8 @@ | |||
| <MicrosoftExtensionsLoggingConsoleVersion>6.0.0</MicrosoftExtensionsLoggingConsoleVersion> | |||
| <MicrosoftIdentityModelClientsActiveDirectoryVersion>3.13.8</MicrosoftIdentityModelClientsActiveDirectoryVersion> | |||
| <MicrosoftInternalPerformanceCodeMarkersDesignTimeVersion>15.8.27812-alpha</MicrosoftInternalPerformanceCodeMarkersDesignTimeVersion> | |||
| <MicrosoftInternalVisualStudioInteropVersion>$(MicrosoftVisualStudioShellPackagesVersion)</MicrosoftInternalVisualStudioInteropVersion> | |||
| <MicrosoftInternalVisualStudioShellFrameworkVersion>$(MicrosoftVisualStudioShellPackagesVersion)</MicrosoftInternalVisualStudioShellFrameworkVersion> | |||
| <MicrosoftInternalVisualStudioInteropVersion>17.7.35005-preview.1</MicrosoftInternalVisualStudioInteropVersion> | |||
There was a problem hiding this comment.
set MicrosoftVisualStudioShellPackagesVersion to 17.7.35005-preview.1 instead
|
@genlu ptal. |
genlu
reviewed
Jun 8, 2023
| internal abstract partial class AbstractStructureTaggerProvider : | ||
| AsynchronousTaggerProvider<IStructureTag> | ||
| #pragma warning disable CS0618 // Type or member is obsolete | ||
| internal abstract partial class AbstractStructureTaggerProvider : AsynchronousTaggerProvider<IStructureTag2> |
There was a problem hiding this comment.
Looks like IStructureTag2 is no longer experimental, wonder if we could use a newer editor package to avoid the suppression
https://devdiv.visualstudio.com/DevDiv/_git/VS-Platform?path=/src/Editor/Text/Def/TextUI/Tags/IStructureTag2.cs
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this:
Specifically, prior to this change, the
if (true)part is gone, and you'd only see:This work was done by populating a new
PrimaryHeaderSpanproperty onIStructureTagso that the block for theelsespan can state that it is associated with theifspan.