Skip to content

Conversation

@AlekseyTs
Copy link
Contributor

No description provided.

CyrusNajmabadi and others added 30 commits February 5, 2025 14:55
…hen they have a large number of elements in them

Search related type sections in other documents when doing a document-filtered nav to search

Use null for simplicity

Apply suggestions from code review

Keep around large array instances for speedometer

Use a separate pool

Make consistent

Revert

Expose similar api on string builder
Co-authored-by: Todd Grunke <toddgrun@microsoft.com>
…ID 327: Build ID 2635853 (dotnet#77075)

Backport of dotnet#77068 to main

/cc @JoeRobich @dotnet-bot

## Customer Impact

## Regression

- [ ] Yes
- [ ] No

[If yes, specify when the regression was introduced. Provide the PR or
commit if known.]

## Testing

[How was the fix verified? How was the issue missed previously? What
tests were added?]

## Risk

[High/Medium/Low. Justify the indication by mentioning how risks were
measured and addressed.]
fixes issue where whitespace gets added twice for completion items that
have upfront text edits.
CyrusNajmabadi and others added 10 commits February 13, 2025 11:49
…net#77168)

This method shows up as 0.8% of VS allocations during typing in the CSharpEditingTests.ScrollingAndTyping speedometer test. These changes should cut this in under half.

This method was previously using string.Split, which allocates an int[] for processing and allocates a return array. Instead, we can roll our own here and avoid both of those allocations
@AlekseyTs AlekseyTs added Area-Compilers Feature - Extension Everything The extension everything feature labels Feb 14, 2025
@AlekseyTs AlekseyTs requested review from jcouv and jjonescz February 14, 2025 00:12
@AlekseyTs AlekseyTs requested review from a team as code owners February 14, 2025 00:12
@ghost ghost added the untriaged Issues and PRs which have not yet been triaged by a lead label Feb 14, 2025
@dotnet-policy-service dotnet-policy-service bot added VSCode Needs UX Triage Needs API Review Needs to be reviewed by the API review council labels Feb 14, 2025
@dotnet-policy-service
Copy link
Contributor

This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging.

@AlekseyTs AlekseyTs merged commit 52fe131 into dotnet:features/extensions Feb 14, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Feature - Extension Everything The extension everything feature Needs API Review Needs to be reviewed by the API review council Needs UX Triage untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Development

Successfully merging this pull request may close these issues.