Skip to content

Add LSP handler for custom requests #77444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 177 commits into from
Apr 5, 2025
Merged

Add LSP handler for custom requests #77444

merged 177 commits into from
Apr 5, 2025

Conversation

@matteo-prosperi
Copy link
Contributor

@matteo-prosperi matteo-prosperi commented Mar 5, 2025

This replaces #77400, the old PR has some relevant comments

JoeRobich and others added 15 commits September 17, 2024 04:25
@JoeRobich
Add LSP handler to test Gladstone integration
c199622
@matteo-prosperi
Updating to match Gladstone and Editor side changes
df4d5a8
@JoeRobich
Merge pull request #75153 from matteo-prosperi/dev/jorobich/gladstone…
43a1eb8 
…-spike

Updating to match Gladstone and Editor side changes
@JoeRobich
Execute handler from extension assembly
5e5f4ba
@JoeRobich
Fix bad merge
f28a75e
@matteo-prosperi
Adding back code to handle LinePosition values correctly
7d14102
@JoeRobich
Merge pull request #75175 from matteo-prosperi/dev/jorobich/gladstone…
220ea5b 
…-spike

Adding back code to handle LinePosition values correctly
@matteo-prosperi
Merge branch 'main' into dev/jorobich/gladstone-spike
8025b6f
@matteo-prosperi
Move the handler to the servicehub process
63018e5
@matteo-prosperi
Better assembly loading logic
620b1a9
@matteo-prosperi
Minor cleanup
48d16b1
@matteo-prosperi
Code improvements
7f7fbd9
@matteo-prosperi
Draft support for unloading handlers
702bfe3
@matteo-prosperi
Addressing feedback
9a9e7ea
@matteo-prosperi
Temporarily add back a converter for LinePosition values
f61ab33
@ghost ghost added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 5, 2025
@matteo-prosperi matteo-prosperi mentioned this pull request Mar 5, 2025
Closed
@build-analysis build-analysis bot mentioned this pull request Mar 7, 2025
Closed
3 tasks
@dotnet-policy-service dotnet-policy-service bot added the Needs API Review Needs to be reviewed by the API review council label Mar 12, 2025
@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review April 4, 2025 16:47
@CyrusNajmabadi CyrusNajmabadi requested review from a team as code owners April 4, 2025 16:47
@CyrusNajmabadi CyrusNajmabadi enabled auto-merge April 4, 2025 17:27
CyrusNajmabadi
CyrusNajmabadi reviewed Apr 4, 2025
View reviewed changes
@CyrusNajmabadi CyrusNajmabadi merged commit 945dc6a into main Apr 5, 2025
28 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 5, 2025
@CyrusNajmabadi CyrusNajmabadi deleted the dev/maprospe/gladstone-spike branch April 5, 2025 01:44
This was referenced Apr 19, 2025
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request May 31, 2025
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmat tmat tmat left review comments

@jaredpar jaredpar jaredpar left review comments

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@dibarbet dibarbet dibarbet approved these changes

Assignees

No one assigned

Labels

Area-Infrastructure Needs API Review Needs to be reviewed by the API review council untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Milestone

18.0 P1

Development

Successfully merging this pull request may close these issues.

8 participants

@matteo-prosperi @CyrusNajmabadi @tmat @jaredpar @dibarbet @RikkiGibson @JoeRobich