Simple and safe performance changes to package load code. #77561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
ToddGrun
commented
Mar 12, 2025
|
|
||
| protected override async Task InitializeAsync(CancellationToken cancellationToken, IProgress<ServiceProgressData> progress) | ||
| { | ||
| await base.InitializeAsync(cancellationToken, progress).ConfigureAwait(true); |
Contributor
Author
ToddGrun
commented
Mar 12, 2025
|
|
||
| await JoinableTaskFactory.SwitchToMainThreadAsync(cancellationToken); | ||
|
|
||
| _componentModel_doNotAccessDirectly = (IComponentModel?)await GetServiceAsync(typeof(SComponentModel)).ConfigureAwait(true); |
Contributor
Author
ToddGrun
commented
Mar 12, 2025
|
|
||
| protected override async Task InitializeAsync(CancellationToken cancellationToken, IProgress<ServiceProgressData> progress) | ||
| { | ||
| await base.InitializeAsync(cancellationToken, progress).ConfigureAwait(true); |
Contributor
Author
ToddGrun
commented
Mar 12, 2025
|
|
||
| await JoinableTaskFactory.SwitchToMainThreadAsync(cancellationToken); | ||
|
|
||
| cancellationToken.ThrowIfCancellationRequested(); |
Contributor
Author
ToddGrun
commented
Mar 12, 2025
|
|
||
| protected override async Task InitializeAsync(CancellationToken cancellationToken, IProgress<ServiceProgressData> progress) | ||
| { | ||
| await base.InitializeAsync(cancellationToken, progress).ConfigureAwait(true); |
Contributor
Author
ToddGrun
commented
Mar 12, 2025
| try | ||
| { | ||
| await base.InitializeAsync(cancellationToken, progress).ConfigureAwait(true); | ||
| await JoinableTaskFactory.SwitchToMainThreadAsync(cancellationToken); |
Contributor
Author
Member
There was a problem hiding this comment.
do we need/want CA(true) on the prior line? if so, doc.
Contributor
Author
There was a problem hiding this comment.
no, we don't want that either, I just missed it in this PR. I'll go ahead and change.
ToddGrun
commented
Mar 12, 2025
| Protected Overrides Async Function InitializeAsync(cancellationToken As CancellationToken, progress As IProgress(Of ServiceProgressData)) As Task | ||
| Try | ||
| Await MyBase.InitializeAsync(cancellationToken, progress).ConfigureAwait(True) | ||
| Await JoinableTaskFactory.SwitchToMainThreadAsync(cancellationToken) |
Contributor
Author
Member
There was a problem hiding this comment.
do we need/want CA(true) on the prior line? if so, doc.
CyrusNajmabadi
approved these changes
Mar 12, 2025
Member
CyrusNajmabadi
left a comment
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
signing off. but i think it wouild be good for these critical sections to doc the intentional behavior here.
Contributor
Author
Agreed, I will add some documentation once things get a little closer to the end target. |
JoeRobich
reviewed
Mar 12, 2025
| _componentModel_doNotAccessDirectly = (IComponentModel?)await GetServiceAsync(typeof(SComponentModel)).ConfigureAwait(true); | ||
| _componentModel_doNotAccessDirectly = (IComponentModel?)await GetServiceAsync(typeof(SComponentModel)).ConfigureAwait(false); | ||
| Assumes.Present(_componentModel_doNotAccessDirectly); | ||
|
|
Member
There was a problem hiding this comment.
nit: feel free to do in a follow up
Suggested change
Contributor
Author
There was a problem hiding this comment.
whoops! I had a whole bunch of logging that I was using for local verification, and looks like I didn't remove the newline that I had next to it.
This was referenced Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 2nd part of a multi-part PR series focused on improving the performance of loading the roslyn packages.
This PR focuses mostly on removing some extraneous potential thread switches.
Part 1: #77439