Switch OnAfterPackageLoadedAsync to use a task queue #77737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes it's behavior to be exactly like InitializeAsync in that it uses this mechanism to minimize thread switches. Also: 1) Renamed PackageRegistrationTasks to PackageLoadTasks 2) Removed the IProgress paramater as it wasn't used and doesn't fit well with OnAfterPackageLoadedAsync 3) Moved service broker service proffering to background thread
ghost
added
Area-IDE
untriaged
CyrusNajmabadi
approved these changes
Mar 21, 2025
…terPackageLoadedAsyncAlso2
Member
|
@ToddGrun I replied to your replies in the other PR, but consider me implicitly signing off on this if that's signed off on. |
This was referenced Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(another attempt at #77687)
This changes it's behavior to be exactly like InitializeAsync in that it uses this mechanism to minimize thread switches.
Also: