Stop using the rename dashboard #77743
Conversation
ghost
added
Area-IDE
untriaged
| { | ||
| dashboard.FocusNextElement(); | ||
| } | ||
| } |
There was a problem hiding this comment.
removed as it will always be false to get the RenameDashboard now, and that was the only codepath that did anything.
| _trackedSession.ReplacementTextChanged -= InlineRenameSession_ReplacementTextChanged; | ||
| } | ||
|
|
||
| if (!_globalOptionService.GetOption(InlineRenameUIOptionsStorage.UseInlineAdornment)) |
There was a problem hiding this comment.
always effectively true now, so this block does nothing.
|
|
||
| internal abstract partial class AbstractRenameCommandHandler : | ||
| IChainedCommandHandler<TabKeyCommandArgs>, | ||
| IChainedCommandHandler<BackTabKeyCommandArgs> |
There was a problem hiding this comment.
tab handling was only handled by the Dashboard, not the Flyout, so this can all be removed.
| // Disable new rename UI for now, it's causing these tests to fail. | ||
| // https://github.com/dotnet/roslyn/issues/63576 | ||
| var globalOptions = await TestServices.Shell.GetComponentModelServiceAsync<IGlobalOptionService>(HangMitigatingCancellationToken); | ||
| globalOptions.SetGlobalOption(InlineRenameUIOptionsStorage.UseInlineAdornment, false); |
There was a problem hiding this comment.
this is concerning as it means our tests aren't validating proper behavior in user scenarios. if this fails, i will disable this test as we have a tracking issue on it already.
There was a problem hiding this comment.
If you disable the test please re-open the tracking issue
ryzngard
left a comment
ryzngard
left a comment
There was a problem hiding this comment.
LGTM. Thanks for cleaning up!
CyrusNajmabadi
merged commit a48562d
into
dotnet:release/dev17.15
3 participants
This feature was added back in 2022: #59779
We don't need the old UI anymore at this point.