Remove the ProjectDiagnosticAnalyzer type #77899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…badi/roslyn into removeProjectAnalyzer
ghost
added
Area-IDE
untriaged
Member
Author
|
TS PR has gone in. So we can remove this now. |
CyrusNajmabadi
commented
Apr 2, 2025
| public async Task TestHostAnalyzerErrorNotLeaking() | ||
| { | ||
| using var workspace = CreateWorkspace(); | ||
|
|
Member
Author
There was a problem hiding this comment.
view with whitespace off.
tmat
approved these changes
Apr 2, 2025
Member
|
Are we going to be able to remove DocumentDiagnosticAnalyzer as well? |
Member
Author
|
Not yet. We use it for file-content-load and sg-error diagnostic reporting. |
CyrusNajmabadi
added a commit
to CyrusNajmabadi/roslyn
that referenced
this pull request
Apr 2, 2025
arunchndr
added a commit
that referenced
this pull request
Apr 2, 2025
CyrusNajmabadi
added a commit
to CyrusNajmabadi/roslyn
that referenced
this pull request
Apr 2, 2025
…otnet#77969) This reverts commit b5d7ffb, reversing changes made to 4ff7d42.
CyrusNajmabadi
added a commit
that referenced
this pull request
Apr 8, 2025
…#77970) This reverts commit b5d7ffb, reversing changes made to 4ff7d42. This can go in now that TS has merged into d18initial: https://devdiv.visualstudio.com/DevDiv/_git/VS?path=/.corext/Configs/components.json&version=GBmain&line=465&lineEnd=469&lineStartColumn=1&lineEndColumn=7&lineStyle=plain&_a=contents
dibarbet
added a commit
to dibarbet/roslyn
that referenced
this pull request
Apr 17, 2025
)" (dotnet#77969) (dotnet#77970)" This reverts commit e2d8d46, reversing changes made to ad71cae.
This was referenced Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently 'draft' as this depends on TypeScript having moved entirely to LSP pull diagnostics.
TS pr to move them off of us is here: https://devdiv.visualstudio.com/DevDiv/_git/TypeScript-VS/pullrequest/623063