Avoid computations in AnalyzerAssemblyLoader.AddDependencyLocation #77919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, this method is calculating some data upfront for the value part of a TryAdd call. Instead, defer calculating that data until after we've determine it's not already in the dictionary. I saw this accounting for 2.3% of CPU during loading Roslyn.sln. With this change, it was about 0.2%.
ghost
added
Area-Analyzers
untriaged
RikkiGibson
reviewed
Mar 31, 2025
| { | ||
| if (_originalPathInfoMap.TryGetValue(originalPath, out var originalPathInfo)) | ||
| { | ||
| Debug.Assert(GeneratedPathComparer.Equals(_originalPathInfoMap[originalPath].ResolvedPath, originalPathInfo.ResolvedPath)); |
Member
There was a problem hiding this comment.
I didn't fully understand what this assert is verifying.
Contributor
Author
There was a problem hiding this comment.
I tried to match the code in the else clause of the TryAdd call below it, but that's pretty much not useful in this case
jaredpar
approved these changes
Mar 31, 2025
RikkiGibson
approved these changes
Mar 31, 2025
This was referenced Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this method is calculating some data upfront for the value part of a TryAdd call. Instead, defer calculating that data until after we've determine it's not already in the dictionary.
I saw this accounting for 2.3% of CPU during loading Roslyn.sln. With this change, it was about 0.2%.
*** original CPU usage opening Roslyn.sln ***
*** CPU usage with this change opening Roslyn.sln ***
