Update gladstone/roslyn api #78057
Update gladstone/roslyn api #78057
Conversation
ghost
added
Area-IDE
untriaged
|
@dibarbet @matteo-prosperi this is ready for review. |
| [property: JsonPropertyName("response"), JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)] string? Response, | ||
| [property: JsonPropertyName("extensionWasUnloaded"), JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingDefault)] bool ExtensionWasUnloaded, | ||
| [property: JsonPropertyName("extensionException"), JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)] | ||
| ExtensionException? ExtensionException); |
There was a problem hiding this comment.
@matteo-prosperi up to you what you will do with this info on the gladstone side.
|
|
||
| // Report any exceptions the extension itself caused while registering and getting the message names. | ||
| if (handlerNames.ExtensionException is not null) | ||
| context.Logger.LogException(handlerNames.ExtensionException); |
There was a problem hiding this comment.
@dibarbet i'm still logging this here (as well as passing back to Gladstone). is that ok with you ?
| internal readonly record struct ExtensionMessageResponse( | ||
| [property: JsonPropertyName("response")] string Response); | ||
| [property: JsonPropertyName("response"), JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)] string? Response, | ||
| [property: JsonPropertyName("extensionWasUnloaded"), JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingDefault)] bool ExtensionWasUnloaded, |
There was a problem hiding this comment.
New field to represent a supported failure mode that does not return a respone and was not an exception itself throwing an exception.
| namespace Microsoft.CodeAnalysis.LanguageServer.Handler.Extensions; | ||
|
|
||
| internal sealed record class ExtensionException( | ||
| [property: JsonPropertyName("typeName")] string TypeName, |
There was a problem hiding this comment.
I'm fine with this - however I would have naively started with serializing System.Exception - I assume we don't want that here? I know the exception type may not exist on the other side, but that is something jsonrpc already has to deal with when we throw exceptions for example.
3 participants
Dependent on #78056