Skip to content

Write ETW event for CreateNonLockingLoader #78177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025
Merged

Write ETW event for CreateNonLockingLoader #78177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Compilers/Core/Portable/CodeAnalysisEventSource.Common.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,9 @@ internal unsafe void NodeTransform(int nodeHashCode, string name, string tableTy
[Event(11, Message = "ALC for directory '{0}' disposal failed with exception '{1}'", Keywords = Keywords.Performance, Level = EventLevel.Error, Opcode = EventOpcode.Stop, Task = Tasks.AnalyzerAssemblyLoader)]
internal void DisposeAssemblyLoadContextException(string directory, string errorMessage) => WriteEvent(11, directory, errorMessage);

[Event(12, Message = "CreateNonLockingLoader", Keywords = Keywords.Performance, Level = EventLevel.Informational, Task = Tasks.AnalyzerAssemblyLoader)]
internal void CreateNonLockingLoader(string directory) => WriteEvent(12, directory);

private static unsafe EventData GetEventDataForString(string value, char* ptr)
{
fixed (char* ptr2 = value)
Expand Down
2 changes: 2 additions & 0 deletions src/Compilers/Core/Portable/DiagnosticAnalyzer/AnalyzerAssemblyLoader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,7 @@ internal static IAnalyzerAssemblyLoaderInternal CreateNonLockingLoader(
ImmutableArray<IAnalyzerAssemblyResolver> assemblyResolvers = default,
System.Runtime.Loader.AssemblyLoadContext? compilerLoadContext = null)
{
CodeAnalysisEventSource.Log.CreateNonLockingLoader(windowsShadowPath);
pathResolvers = pathResolvers.NullToEmpty();
assemblyResolvers = assemblyResolvers.NullToEmpty();

Expand Down Expand Up @@ -448,6 +449,7 @@ internal static IAnalyzerAssemblyLoaderInternal CreateNonLockingLoader(
string windowsShadowPath,
ImmutableArray<IAnalyzerPathResolver> pathResolvers = default)
{
CodeAnalysisEventSource.Log.CreateNonLockingLoader(windowsShadowPath);
pathResolvers = pathResolvers.NullToEmpty();

// The goal here is to avoid locking files on disk that are reasonably expected to be changed by
Expand Down