Skip to content

Address some PROTOTYPE comments #78241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

Address some PROTOTYPE comments #78241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Compilers/CSharp/Portable/Binder/Binder_Operators.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2714,7 +2714,9 @@ static void appendViableMethods(LookupResult lookupResult, int parameterCount, A

static bool isViable(MethodSymbol method, int parameterCount)
{
return method.ParameterCount == parameterCount;
Debug.Assert(parameterCount is 0 or 1);
return method.ParameterCount == parameterCount && method.ReturnsVoid && !method.IsVararg &&
(parameterCount == 0 || method.Parameters[0].RefKind is RefKind.None or RefKind.In);
}
}

Expand Down
2 changes: 0 additions & 2 deletions src/Compilers/CSharp/Portable/Symbols/Metadata/PE/PEMethodSymbol.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1173,8 +1173,6 @@ private bool HasValidOperatorParameterRefKinds()

private bool IsValidInstanceUserDefinedOperatorSignature(int parameterCount)
{
// PROTOTYPE: Cover negative scenarios

if (!this.ReturnsVoid || this.IsGenericMethod || this.IsVararg || this.ParameterCount != parameterCount || this.IsParams())
{
return false;
Expand Down
4 changes: 0 additions & 4 deletions src/Compilers/CSharp/Portable/Symbols/Source/SourceUserDefinedOperatorSymbolBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ protected SourceUserDefinedOperatorSymbolBase(
}
else
{
// PROTOTYPE: Cover explicit implementation scenarios

Binder.CheckFeatureAvailability(syntax, MessageID.IDS_FeatureUserDefinedCompoundAssignmentOperators, diagnostics, ((OperatorDeclarationSyntax)syntax).OperatorToken.GetLocation());

if (parameterCount is not (0 or 2))
Expand All @@ -78,7 +76,6 @@ protected SourceUserDefinedOperatorSymbolBase(
}
else if (isCompoundAssignment)
{
// PROTOTYPE: Cover explicit implementation scenarios
Binder.CheckFeatureAvailability(syntax, MessageID.IDS_FeatureUserDefinedCompoundAssignmentOperators, diagnostics, ((OperatorDeclarationSyntax)syntax).OperatorToken.GetLocation());
}

Expand Down Expand Up @@ -566,7 +563,6 @@ private void CheckOperatorSignatures(BindingDiagnosticBag diagnostics)
diagnostics.Add(ErrorCode.ERR_OperatorMustReturnVoid, this.GetFirstLocation());
}

// PROTOTYPE: Test/handle scenarios with ref modifiers on the parameter
break;

default:
Expand Down
Loading