Skip to content

Fix debugging of build tasks #78271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2025
Merged

Fix debugging of build tasks #78271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcec870
Fix debugging of build tasks
jjonescz Apr 23, 2025
72d9b16
Split into a new target
jjonescz Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .vscode/tasks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@
"command": "dotnet",
"args": [
"build",
Copy link
Member

@jasonmalinowski jasonmalinowski Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just easier to have this do 'pack'? that way you'll get the full build that way.

Copy link
Member Author

@jjonescz jjonescz Apr 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pack doesn't put all the DLLs into one folder as needed for debugging, it just copies them from all the referenced projects' bin folders directly into the nupkg.

"-p:InnerTargets=CopyFilesForDebugging",
"-p:GenerateFullPaths=true",
"${workspaceFolder}/src/NuGet/Microsoft.Net.Compilers.Toolset/AnyCpu/Microsoft.Net.Compilers.Toolset.Package.csproj"
],
Expand Down
6 changes: 4 additions & 2 deletions ...Get/Microsoft.Net.Compilers.Toolset/AnyCpu/Microsoft.Net.Compilers.Toolset.Package.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,11 @@

<TfmSpecificPackageFile Include="@(_FileWithPath)" PackagePath="%(_FileWithPath.TargetPath)" />
</ItemGroup>
</Target>

<!-- Used for debugging parts of the toolset (e.g., build tasks).
Doesn't work in VS (where `<ProjectReference Targets="Publish" />` doesn't have any effect), hence we set `ContinueOnError="true"`. -->
<!-- Used to lay out all DLLs in one folder on disk via `dotnet build -p:InnerTargets=CopyFilesForDebugging`
so they can be then used for debugging parts of the toolset (e.g., build tasks). -->
<Target Name="CopyFilesForDebugging" DependsOnTargets="_GetFiles">
<Copy SourceFiles="@(_FileWithPath)"
DestinationFiles="$(BaseOutputPath)$(Configuration)\%(_FileWithPath.TargetPath)"
SkipUnchangedFiles="true" />
Comment on lines 69 to 71
Copy link
Member

@jasonmalinowski jasonmalinowski Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What might be cleaner would be to move this copy to a separate target that depends on _GetFiles, and then point to that target in your VS Code path. Otherwise you might still be producing files that nobody is looking at.

Expand Down